From 0c25d663f8858d2398e539240959d14cf518ac52 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Munsch?= Date: Mon, 17 Aug 2026 09:41:10 +0200 Subject: [PATCH] refactor: add explicit types to class constants (PHP 8.3+) --- src/Domain/Models/ValueObjects/Employees/ArcadiaEmployeeId.php | 2 +- src/Domain/Models/ValueObjects/EstablishmentCode.php | 2 +- .../Models/ValueObjects/Inco/Composition/IncoCompositionId.php | 2 +- src/Domain/Models/ValueObjects/Inco/IncoId.php | 2 +- src/Domain/Models/ValueObjects/Inco/PortionAmount.php | 2 +- src/Domain/Models/ValueObjects/ServiceId.php | 2 +- src/Domain/Models/ValueObjects/SiteId.php | 2 +- .../Adapters/Directories/EloquentIncoShortSheetDirectory.php | 3 ++- src/Shared/Pagination.php | 2 +- 9 files changed, 10 insertions(+), 9 deletions(-) diff --git a/src/Domain/Models/ValueObjects/Employees/ArcadiaEmployeeId.php b/src/Domain/Models/ValueObjects/Employees/ArcadiaEmployeeId.php index 559eab0..29f2bc9 100644 --- a/src/Domain/Models/ValueObjects/Employees/ArcadiaEmployeeId.php +++ b/src/Domain/Models/ValueObjects/Employees/ArcadiaEmployeeId.php @@ -8,7 +8,7 @@ use Shared\DDD\EntityId; final readonly class ArcadiaEmployeeId extends EntityId { - private const PATTERN = '/^\d{7,8}$/'; + private const string PATTERN = '/^\d{7,8}$/'; public function __construct( public readonly string $value diff --git a/src/Domain/Models/ValueObjects/EstablishmentCode.php b/src/Domain/Models/ValueObjects/EstablishmentCode.php index ed864b0..e7dbfa3 100644 --- a/src/Domain/Models/ValueObjects/EstablishmentCode.php +++ b/src/Domain/Models/ValueObjects/EstablishmentCode.php @@ -6,7 +6,7 @@ namespace Domain\Models\ValueObjects; final readonly class EstablishmentCode { - private const PATTERN = '/^[\dA-Z]{2,}$/'; + private const string PATTERN = '/^[\dA-Z]{2,}$/'; public function __construct( public readonly string $value diff --git a/src/Domain/Models/ValueObjects/Inco/Composition/IncoCompositionId.php b/src/Domain/Models/ValueObjects/Inco/Composition/IncoCompositionId.php index 101ba49..152eb89 100644 --- a/src/Domain/Models/ValueObjects/Inco/Composition/IncoCompositionId.php +++ b/src/Domain/Models/ValueObjects/Inco/Composition/IncoCompositionId.php @@ -8,7 +8,7 @@ use Shared\DDD\EntityId; final readonly class IncoCompositionId extends EntityId { - private const PATTERN = '/^\d{1,}$/'; + private const string PATTERN = '/^\d{1,}$/'; public function __construct( public readonly string $value diff --git a/src/Domain/Models/ValueObjects/Inco/IncoId.php b/src/Domain/Models/ValueObjects/Inco/IncoId.php index 5399472..98da50c 100644 --- a/src/Domain/Models/ValueObjects/Inco/IncoId.php +++ b/src/Domain/Models/ValueObjects/Inco/IncoId.php @@ -8,7 +8,7 @@ use Shared\DDD\EntityId; final readonly class IncoId extends EntityId { - private const PATTERN = '/^\d{1,}$/'; + private const string PATTERN = '/^\d{1,}$/'; public function __construct( public readonly string $value diff --git a/src/Domain/Models/ValueObjects/Inco/PortionAmount.php b/src/Domain/Models/ValueObjects/Inco/PortionAmount.php index 323df80..b4a6d1b 100644 --- a/src/Domain/Models/ValueObjects/Inco/PortionAmount.php +++ b/src/Domain/Models/ValueObjects/Inco/PortionAmount.php @@ -29,7 +29,7 @@ final readonly class PortionAmount /** * The number of decimals allowed, this should not change */ - private const ALLOWED_DECIMAL_SIZE = 2; + private const int ALLOWED_DECIMAL_SIZE = 2; /** * NbPortion diff --git a/src/Domain/Models/ValueObjects/ServiceId.php b/src/Domain/Models/ValueObjects/ServiceId.php index caf6854..6b4a9aa 100644 --- a/src/Domain/Models/ValueObjects/ServiceId.php +++ b/src/Domain/Models/ValueObjects/ServiceId.php @@ -9,7 +9,7 @@ namespace Domain\Models\ValueObjects; */ final readonly class ServiceId { - private const PATTERN = '/^\d{1,}$/'; + private const string PATTERN = '/^\d{1,}$/'; public function __construct( public readonly string $value diff --git a/src/Domain/Models/ValueObjects/SiteId.php b/src/Domain/Models/ValueObjects/SiteId.php index 9935f2a..58d883a 100644 --- a/src/Domain/Models/ValueObjects/SiteId.php +++ b/src/Domain/Models/ValueObjects/SiteId.php @@ -9,7 +9,7 @@ namespace Domain\Models\ValueObjects; */ final readonly class SiteId { - private const PATTERN = '/^[A-Z]{2,}$/'; + private const string PATTERN = '/^[A-Z]{2,}$/'; public function __construct( public readonly string $value diff --git a/src/Infra/Adapters/Directories/EloquentIncoShortSheetDirectory.php b/src/Infra/Adapters/Directories/EloquentIncoShortSheetDirectory.php index a3e9722..d7096a3 100644 --- a/src/Infra/Adapters/Directories/EloquentIncoShortSheetDirectory.php +++ b/src/Infra/Adapters/Directories/EloquentIncoShortSheetDirectory.php @@ -18,7 +18,8 @@ use Shared\Pagination; final class EloquentIncoShortSheetDirectory implements IncoShortSheetDirectory { - private const SHORT_FIELDS = ['id', 'name', 'label', 'created_at', 'updated_at']; + /** @var list */ + private const array SHORT_FIELDS = ['id', 'name', 'label', 'created_at', 'updated_at']; #[\Override] public function findAll( diff --git a/src/Shared/Pagination.php b/src/Shared/Pagination.php index 8f0ad77..253b552 100644 --- a/src/Shared/Pagination.php +++ b/src/Shared/Pagination.php @@ -10,7 +10,7 @@ namespace Shared; final readonly class Pagination { /** ERR_TOO_MANY_RECORDS fixed to 10k */ - public const MAX_PAGE_SIZE = 10000; + public const int MAX_PAGE_SIZE = 10000; public function __construct( private int $from,