From 195227a44342f51b44d6cdfd5bfeee5c42aca76a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Munsch?= Date: Fri, 14 Aug 2026 12:13:11 +0200 Subject: [PATCH] style(dto): update parameter formatting in DTO constructors style(dto): simplify toArray method by removing unnecessary variable assignment --- .../Api/V1/Dto/IncoSheets/Parts/AdditiveDto.php | 5 ++--- .../Api/V1/Dto/IncoSheets/Parts/AllegationsDto.php | 13 ++++++------- .../Api/V1/Dto/IncoSheets/Parts/AllergenDto.php | 5 ++--- .../Api/V1/Dto/IncoSheets/Parts/BrandDto.php | 5 ++--- .../Api/V1/Dto/IncoSheets/Parts/NutriscoreDto.php | 5 ++--- .../Api/V1/Dto/IncoSheets/Parts/PortionsDto.php | 5 ++--- .../V1/Dto/IncoSheets/Parts/StorageConditionDto.php | 5 ++--- .../Api/V1/Dto/IncoSheets/Parts/WeightDto.php | 5 ++--- .../IncoSheets/IncoSheetsIndexResponse.php | 2 +- 9 files changed, 21 insertions(+), 29 deletions(-) diff --git a/src/Presentation/Api/V1/Dto/IncoSheets/Parts/AdditiveDto.php b/src/Presentation/Api/V1/Dto/IncoSheets/Parts/AdditiveDto.php index 7201d7c..41d8222 100644 --- a/src/Presentation/Api/V1/Dto/IncoSheets/Parts/AdditiveDto.php +++ b/src/Presentation/Api/V1/Dto/IncoSheets/Parts/AdditiveDto.php @@ -26,8 +26,7 @@ final readonly class AdditiveDto implements ApiResponseDto #[\Override] public function toArray(): array { - /** @var array $vars */ - $vars = get_object_vars($this); - return $vars; + /** @var array */ + return get_object_vars($this); } } diff --git a/src/Presentation/Api/V1/Dto/IncoSheets/Parts/AllegationsDto.php b/src/Presentation/Api/V1/Dto/IncoSheets/Parts/AllegationsDto.php index ef2f8c5..fcf1197 100644 --- a/src/Presentation/Api/V1/Dto/IncoSheets/Parts/AllegationsDto.php +++ b/src/Presentation/Api/V1/Dto/IncoSheets/Parts/AllegationsDto.php @@ -10,10 +10,10 @@ use Presentation\Api\V1\Contracts\ApiResponseDto; final readonly class AllegationsDto implements ApiResponseDto { /** - * @param array $allegations - * @param array $health - * @param array $nutrition - * @param array $other + * @param array $allegations + * @param array $health + * @param array $nutrition + * @param array $other */ public function __construct( public array $allegations, @@ -36,8 +36,7 @@ final readonly class AllegationsDto implements ApiResponseDto #[\Override] public function toArray(): array { - /** @var array $vars */ - $vars = get_object_vars($this); - return $vars; + /** @var array */ + return get_object_vars($this); } } diff --git a/src/Presentation/Api/V1/Dto/IncoSheets/Parts/AllergenDto.php b/src/Presentation/Api/V1/Dto/IncoSheets/Parts/AllergenDto.php index 3ff20b6..8c5d666 100644 --- a/src/Presentation/Api/V1/Dto/IncoSheets/Parts/AllergenDto.php +++ b/src/Presentation/Api/V1/Dto/IncoSheets/Parts/AllergenDto.php @@ -26,8 +26,7 @@ final readonly class AllergenDto implements ApiResponseDto #[\Override] public function toArray(): array { - /** @var array $vars */ - $vars = get_object_vars($this); - return $vars; + /** @var array */ + return get_object_vars($this); } } diff --git a/src/Presentation/Api/V1/Dto/IncoSheets/Parts/BrandDto.php b/src/Presentation/Api/V1/Dto/IncoSheets/Parts/BrandDto.php index e6349d1..3fd1422 100644 --- a/src/Presentation/Api/V1/Dto/IncoSheets/Parts/BrandDto.php +++ b/src/Presentation/Api/V1/Dto/IncoSheets/Parts/BrandDto.php @@ -26,8 +26,7 @@ final readonly class BrandDto implements ApiResponseDto #[\Override] public function toArray(): array { - /** @var array $vars */ - $vars = get_object_vars($this); - return $vars; + /** @var array */ + return get_object_vars($this); } } diff --git a/src/Presentation/Api/V1/Dto/IncoSheets/Parts/NutriscoreDto.php b/src/Presentation/Api/V1/Dto/IncoSheets/Parts/NutriscoreDto.php index 00af9f2..d7da5f6 100644 --- a/src/Presentation/Api/V1/Dto/IncoSheets/Parts/NutriscoreDto.php +++ b/src/Presentation/Api/V1/Dto/IncoSheets/Parts/NutriscoreDto.php @@ -24,8 +24,7 @@ final readonly class NutriscoreDto implements ApiResponseDto #[\Override] public function toArray(): array { - /** @var array $vars */ - $vars = get_object_vars($this); - return $vars; + /** @var array */ + return get_object_vars($this); } } diff --git a/src/Presentation/Api/V1/Dto/IncoSheets/Parts/PortionsDto.php b/src/Presentation/Api/V1/Dto/IncoSheets/Parts/PortionsDto.php index 5ca1e9a..0bd47e5 100644 --- a/src/Presentation/Api/V1/Dto/IncoSheets/Parts/PortionsDto.php +++ b/src/Presentation/Api/V1/Dto/IncoSheets/Parts/PortionsDto.php @@ -28,8 +28,7 @@ final readonly class PortionsDto implements ApiResponseDto #[\Override] public function toArray(): array { - /** @var array $vars */ - $vars = get_object_vars($this); - return $vars; + /** @var array */ + return get_object_vars($this); } } diff --git a/src/Presentation/Api/V1/Dto/IncoSheets/Parts/StorageConditionDto.php b/src/Presentation/Api/V1/Dto/IncoSheets/Parts/StorageConditionDto.php index f530ae4..7156873 100644 --- a/src/Presentation/Api/V1/Dto/IncoSheets/Parts/StorageConditionDto.php +++ b/src/Presentation/Api/V1/Dto/IncoSheets/Parts/StorageConditionDto.php @@ -24,8 +24,7 @@ final readonly class StorageConditionDto implements ApiResponseDto #[\Override] public function toArray(): array { - /** @var array $vars */ - $vars = get_object_vars($this); - return $vars; + /** @var array */ + return get_object_vars($this); } } diff --git a/src/Presentation/Api/V1/Dto/IncoSheets/Parts/WeightDto.php b/src/Presentation/Api/V1/Dto/IncoSheets/Parts/WeightDto.php index 5da059c..4110734 100644 --- a/src/Presentation/Api/V1/Dto/IncoSheets/Parts/WeightDto.php +++ b/src/Presentation/Api/V1/Dto/IncoSheets/Parts/WeightDto.php @@ -28,8 +28,7 @@ final readonly class WeightDto implements ApiResponseDto #[\Override] public function toArray(): array { - /** @var array $vars */ - $vars = get_object_vars($this); - return $vars; + /** @var array */ + return get_object_vars($this); } } diff --git a/src/Presentation/Api/V1/Http/Responses/IncoSheets/IncoSheetsIndexResponse.php b/src/Presentation/Api/V1/Http/Responses/IncoSheets/IncoSheetsIndexResponse.php index d8dd943..94ba5e7 100644 --- a/src/Presentation/Api/V1/Http/Responses/IncoSheets/IncoSheetsIndexResponse.php +++ b/src/Presentation/Api/V1/Http/Responses/IncoSheets/IncoSheetsIndexResponse.php @@ -39,7 +39,7 @@ final readonly class IncoSheetsIndexResponse implements ApiResponse ); $items = array_map( - fn (PaginatedIncoSheet|PaginatedShortIncoSheet $sheet): array => $sheet instanceof PaginatedShortIncoSheet + fn (PaginatedIncoSheet | PaginatedShortIncoSheet $sheet): array => $sheet instanceof PaginatedShortIncoSheet ? IncoShortSheetDto::fromPaginatedShortIncoSheet($sheet)->toArray() : IncoSheetDto::fromPaginatedIncoSheet($sheet)->toArray(), $this->view->incoSheets