From 6f35e031fa4b80e516cb872c29cbed7512dc64a1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Munsch?= Date: Thu, 20 Aug 2026 17:35:26 +0200 Subject: [PATCH] refactor(presentation): remove authorize method from FormRequests in favor of middleware filters --- .../Api/V1/Http/Requests/Employees/EmployeeShowRequest.php | 5 ----- .../Api/V1/Http/Requests/Employees/EmployeesIndexRequest.php | 5 ----- .../Requests/IncoCompositions/IncoCompositionShowRequest.php | 5 ----- .../V1/Http/Requests/IncoSheets/IncoSheetsIndexRequest.php | 5 ----- .../V1/Http/Requests/IncoSheets/IncoSheetsSearchRequest.php | 5 ----- .../V1/Http/Requests/IncoSheets/IncoSheetsShowRequest.php | 5 ----- tests/Architecture/PresentationTest.php | 4 ++++ 7 files changed, 4 insertions(+), 30 deletions(-) diff --git a/src/Presentation/Api/V1/Http/Requests/Employees/EmployeeShowRequest.php b/src/Presentation/Api/V1/Http/Requests/Employees/EmployeeShowRequest.php index 817f161..ea9b2fc 100644 --- a/src/Presentation/Api/V1/Http/Requests/Employees/EmployeeShowRequest.php +++ b/src/Presentation/Api/V1/Http/Requests/Employees/EmployeeShowRequest.php @@ -17,11 +17,6 @@ final class EmployeeShowRequest extends FormRequest ]; } - public function authorize(): bool - { - return true; - } - protected function prepareForValidation(): void { $this->merge([ diff --git a/src/Presentation/Api/V1/Http/Requests/Employees/EmployeesIndexRequest.php b/src/Presentation/Api/V1/Http/Requests/Employees/EmployeesIndexRequest.php index df7cfd4..65e970e 100644 --- a/src/Presentation/Api/V1/Http/Requests/Employees/EmployeesIndexRequest.php +++ b/src/Presentation/Api/V1/Http/Requests/Employees/EmployeesIndexRequest.php @@ -42,11 +42,6 @@ final class EmployeesIndexRequest extends FormRequest ]; } - public function authorize(): bool - { - return true; - } - public function sorter(): EmployeeSorter { return new EmployeeSorter($this->sortBy(), $this->direction()); diff --git a/src/Presentation/Api/V1/Http/Requests/IncoCompositions/IncoCompositionShowRequest.php b/src/Presentation/Api/V1/Http/Requests/IncoCompositions/IncoCompositionShowRequest.php index bd5e5ac..67e5065 100644 --- a/src/Presentation/Api/V1/Http/Requests/IncoCompositions/IncoCompositionShowRequest.php +++ b/src/Presentation/Api/V1/Http/Requests/IncoCompositions/IncoCompositionShowRequest.php @@ -17,11 +17,6 @@ final class IncoCompositionShowRequest extends FormRequest ]; } - public function authorize(): bool - { - return true; - } - protected function prepareForValidation(): void { $this->merge([ diff --git a/src/Presentation/Api/V1/Http/Requests/IncoSheets/IncoSheetsIndexRequest.php b/src/Presentation/Api/V1/Http/Requests/IncoSheets/IncoSheetsIndexRequest.php index 4e36c92..8451659 100644 --- a/src/Presentation/Api/V1/Http/Requests/IncoSheets/IncoSheetsIndexRequest.php +++ b/src/Presentation/Api/V1/Http/Requests/IncoSheets/IncoSheetsIndexRequest.php @@ -38,11 +38,6 @@ final class IncoSheetsIndexRequest extends FormRequest ]; } - public function authorize(): bool - { - return true; - } - public function sorter(): IncoSheetSorter { return new IncoSheetSorter($this->sortBy(), $this->direction()); diff --git a/src/Presentation/Api/V1/Http/Requests/IncoSheets/IncoSheetsSearchRequest.php b/src/Presentation/Api/V1/Http/Requests/IncoSheets/IncoSheetsSearchRequest.php index 633b800..0b11e28 100644 --- a/src/Presentation/Api/V1/Http/Requests/IncoSheets/IncoSheetsSearchRequest.php +++ b/src/Presentation/Api/V1/Http/Requests/IncoSheets/IncoSheetsSearchRequest.php @@ -24,11 +24,6 @@ final class IncoSheetsSearchRequest extends FormRequest ]; } - public function authorize(): bool - { - return true; - } - public function incoIdSearch(): IncoIdQuery { return new IncoIdQuery($this->string('incoIdLike')->value()); diff --git a/src/Presentation/Api/V1/Http/Requests/IncoSheets/IncoSheetsShowRequest.php b/src/Presentation/Api/V1/Http/Requests/IncoSheets/IncoSheetsShowRequest.php index 0863d5b..71b9d2e 100644 --- a/src/Presentation/Api/V1/Http/Requests/IncoSheets/IncoSheetsShowRequest.php +++ b/src/Presentation/Api/V1/Http/Requests/IncoSheets/IncoSheetsShowRequest.php @@ -17,11 +17,6 @@ final class IncoSheetsShowRequest extends FormRequest ]; } - public function authorize(): bool - { - return true; - } - protected function prepareForValidation(): void { $this->merge([ diff --git a/tests/Architecture/PresentationTest.php b/tests/Architecture/PresentationTest.php index d4efbd6..04cfa8b 100644 --- a/tests/Architecture/PresentationTest.php +++ b/tests/Architecture/PresentationTest.php @@ -31,6 +31,10 @@ describe('Presentation Architecture Rules', function (): void { ->expect('Presentation\Api\V1\Http\Requests') ->not->toHaveMethod('toInput'); + arch('Presentation FormRequests do not contain authorize method (auth is handled in middleware filters)') + ->expect('Presentation\Api\V1\Http\Requests') + ->not->toHaveMethod('authorize'); + arch('Presentation layer uses strict types') ->expect('Presentation') ->toUseStrictTypes();