forge-joniko/ldc-arcadia-api
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test(DatesHelper): update date regex and add instantiation test

Browse source 
- Fixed regex for inverted French date format.
- Added test to prevent direct instantiation of DatesHelper.
This commit is contained in:
Jérémy Munsch 2026-08-13 13:11:55 +02:00
parent aaa39004bc
commit 8afc31c806
Signed by: forge-joniko
GPG key ID: D7EFE2F5CB6CC0E4
2 changed files with 13 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/Shared/Helpers/DatesHelper.php
View file

@ -11,7 +11,7 @@ final class DatesHelper
{
private const string FRENCH_DATE_REGEX = '/^\d{4}-\d{2}-\d{2}$/';
private const string FRENCH_DATE_INVERT_REGEX = '/^\d{2}-\d{2}\d{4}$/';
private const string FRENCH_DATE_INVERT_REGEX = '/^\d{2}-\d{2}-\d{4}$/';
private const string ISO8601_REGEX = '/^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}Z$/';

14
tests/Integration/Shared/Helpers/DateHelperTest.php
View file

@ -10,10 +10,19 @@ use Shared\Helpers\DatesHelper;
covers(DatesHelper::class);
afterEach(function (): void {
\Mockery::close();
CarbonImmutable::setTestNow();
});
describe('Date Helper Integration Tests', function (): void {
it('prevents direct instantiation', function (): void {
// GIVEN
$reflection = new \ReflectionClass(DatesHelper::class);
// WHEN & THEN
expect(fn () => $reflection->newInstance())
->toThrow(\ReflectionException::class);
});
it('can parse various date formats', function (string $input, string $expectedFormat): void {
// GIVEN & WHEN
@ -28,7 +37,8 @@ describe('Date Helper Integration Tests', function (): void {
['25-12-2025', '2025-12-25'],
['2025-12-25T12:10:23Z', '2025-12-25'],
['2025-12-25T12:10:23+02:00', '2025-12-25'],
['2025-12-25T12:10:23.123456Z', '2025-12-25'],
['2025-12-25T12:10:23.123456+02:00', '2025-12-25'],
['2025/12/25', '2025-12-25'],
]);
it('throws InvalidArgumentException for unparseable date strings', function (): void {
@ -37,7 +47,7 @@ describe('Date Helper Integration Tests', function (): void {
// WHEN & THEN
expect(fn () => DatesHelper::parseDateTime($invalidDate))
->toThrow(\InvalidArgumentException::class);
->toThrow(\InvalidArgumentException::class, 'Unrecognized date/time format: not-a-real-date-string');
});
it('handles isIn date boundary checks correctly', function (): void {