refactor(presentation): move transformation logic from views to presenters

This commit is contained in:
Jérémy Munsch 2026-08-18 12:43:01 +02:00
parent a771d8a5d1
commit af416b1b7c
Signed by: forge-joniko
GPG key ID: D7EFE2F5CB6CC0E4
12 changed files with 31 additions and 69 deletions

View file

@ -17,6 +17,16 @@ final readonly class EmployeeShowPresenter implements Presenter
{
Assert::isInstanceOf($output, Output::class);
return EmployeeShowView::fromOutput($output);
return new EmployeeShowView(
id: $output->id,
firstName: $output->firstName,
lastName: $output->lastName,
establishment: $output->establishment,
site: $output->site,
service: $output->service,
startDate: $output->startDate,
endDate: $output->endDate,
plannedEndDate: $output->plannedEndDate,
);
}
}

View file

@ -4,7 +4,6 @@ declare(strict_types=1);
namespace Presentation\Api\V1\Presenters\Employees;
use Application\Arcadia\Usecase\Employees\Find\Output;
use Domain\Models\ValueObjects\Employees\ArcadiaEmployeeId;
final readonly class EmployeeShowView
@ -21,19 +20,4 @@ final readonly class EmployeeShowView
public ?\DateTimeInterface $plannedEndDate,
) {
}
public static function fromOutput(Output $output): self
{
return new self(
id: $output->id,
firstName: $output->firstName,
lastName: $output->lastName,
establishment: $output->establishment,
site: $output->site,
service: $output->service,
startDate: $output->startDate,
endDate: $output->endDate,
plannedEndDate: $output->plannedEndDate,
);
}
}

View file

@ -17,6 +17,11 @@ final readonly class EmployeesIndexPresenter implements Presenter
{
Assert::isInstanceOf($output, Output::class);
return EmployeesIndexView::fromOutput($output);
return new EmployeesIndexView(
employees: $output->employees,
total: $output->total,
page: $output->page,
perPage: $output->perPage,
);
}
}

View file

@ -4,7 +4,6 @@ declare(strict_types=1);
namespace Presentation\Api\V1\Presenters\Employees;
use Application\Arcadia\Usecase\Employees\FindAll\Output;
use Application\Arcadia\Usecase\Employees\FindAll\PaginatedEmployee;
use Webmozart\Assert\Assert;
@ -23,14 +22,4 @@ final readonly class EmployeesIndexView
Assert::isInstanceOf($employee, PaginatedEmployee::class);
}
}
public static function fromOutput(Output $output): self
{
return new self(
employees: $output->employees,
total: $output->total,
page: $output->page,
perPage: $output->perPage,
);
}
}

View file

@ -17,6 +17,6 @@ final readonly class IncoCompositionShowPresenter implements Presenter
{
Assert::isInstanceOf($output, Output::class);
return IncoCompositionShowView::fromOutput($output);
return new IncoCompositionShowView($output);
}
}

View file

@ -12,9 +12,4 @@ final readonly class IncoCompositionShowView
public Output $output,
) {
}
public static function fromOutput(Output $output): self
{
return new self($output);
}
}

View file

@ -17,6 +17,11 @@ final readonly class IncoSheetsIndexPresenter implements Presenter
{
Assert::isInstanceOf($output, Output::class);
return IncoSheetsIndexView::fromOutput($output);
return new IncoSheetsIndexView(
incoSheets: array_values($output->incoSheets),
total: $output->total,
page: $output->page,
perPage: $output->perPage,
);
}
}

View file

@ -4,13 +4,9 @@ declare(strict_types=1);
namespace Presentation\Api\V1\Presenters\IncoSheets;
use Application\Arcadia\Usecase\IncoSheets\FindAll\Output;
final readonly class IncoSheetsIndexView
{
/**
* phpcs:disable Generic.Files.LineLength.TooLong
*
* @param (\Application\Arcadia\Usecase\IncoSheets\FindAll\PaginatedIncoSheet|\Application\Arcadia\Usecase\IncoSheets\FindAll\PaginatedShortIncoSheet)[] $incoSheets
*/
public function __construct(
@ -20,14 +16,4 @@ final readonly class IncoSheetsIndexView
public int $perPage,
) {
}
public static function fromOutput(Output $output): self
{
return new self(
incoSheets: array_values($output->incoSheets),
total: $output->total,
page: $output->page,
perPage: $output->perPage,
);
}
}

View file

@ -17,6 +17,11 @@ final readonly class IncoSheetsSearchPresenter implements Presenter
{
Assert::isInstanceOf($output, Output::class);
return IncoSheetsSearchView::fromOutput($output);
return new IncoSheetsSearchView(
incoSheets: $output->incoSheets,
total: $output->total,
page: $output->page,
perPage: $output->perPage,
);
}
}

View file

@ -4,8 +4,6 @@ declare(strict_types=1);
namespace Presentation\Api\V1\Presenters\IncoSheets;
use Application\Arcadia\Usecase\IncoSheets\Search\Output;
final readonly class IncoSheetsSearchView
{
/**
@ -21,14 +19,4 @@ final readonly class IncoSheetsSearchView
public int $perPage,
) {
}
public static function fromOutput(Output $output): self
{
return new self(
incoSheets: $output->incoSheets,
total: $output->total,
page: $output->page,
perPage: $output->perPage,
);
}
}

View file

@ -17,6 +17,6 @@ final readonly class IncoSheetsShowPresenter implements Presenter
{
Assert::isInstanceOf($output, Output::class);
return IncoSheetsShowView::fromOutput($output);
return new IncoSheetsShowView($output);
}
}

View file

@ -12,9 +12,4 @@ final readonly class IncoSheetsShowView
public Output $output,
) {
}
public static function fromOutput(Output $output): self
{
return new self($output);
}
}