From f30c6cff18466e2905d138dfc56340ccd3a8c405 Mon Sep 17 00:00:00 2001
From: Olivier Legat <olivier.legat@ldc.fr>
Date: Mon, 12 Sep 2022 16:31:08 +0200
Subject: [PATCH] fix product associated optionnal data

---
 .../Controllers/Bo/ProductsController.php     | 24 +++++++++----------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/app/Http/Controllers/Bo/ProductsController.php b/app/Http/Controllers/Bo/ProductsController.php
index af40eeb..8572c68 100644
--- a/app/Http/Controllers/Bo/ProductsController.php
+++ b/app/Http/Controllers/Bo/ProductsController.php
@@ -259,7 +259,7 @@ class ProductsController extends Controller
         $rangeId         = $request->range_id;
         $taxRateId       = $request->tax_rate_id;
 
-        $this->checkSlugExistsWithinRange($rangeId, $slug, $product->id, $request);
+        $this->checkSlugExistsWithinRange($request, $rangeId, $slug, $product->id);
 
         $this->manageProductImages($request->picture, $product, $request->picture_large);
 
@@ -310,13 +310,13 @@ class ProductsController extends Controller
     /**
      * Check if slug already exists, if so redirect
      *
-     * @param integer $rangeId
-     * @param string  $slug
-     * @param integer $productId
-     * @param Request $request
+     * @param Request      $request
+     * @param integer      $rangeId
+     * @param string       $slug
+     * @param integer|null $productId
      * @return \Illuminate\Http\RedirectResponse|void
      */
-    private function checkSlugExistsWithinRange(int $rangeId, string $slug, int $productId, Request $request)
+    private function checkSlugExistsWithinRange(Request $request, int $rangeId, string $slug, int $productId = null)
     {
         // Check si le slug existe déjà dans cette gamme de produits.
         $slugExist = Product::where([
@@ -409,11 +409,11 @@ class ProductsController extends Controller
     /**
      * sync tags to product
      *
-     * @param array   $tags
-     * @param Product $product
+     * @param array|null $tags
+     * @param Product    $product
      * @return void
      */
-    private function syncTags(array $tags, Product &$product)
+    private function syncTags(array $tags = null, Product &$product)
     {
         if (!empty($tags)) {
             $arTagIds = array();
@@ -436,11 +436,11 @@ class ProductsController extends Controller
     /**
      * sync associated products to product
      *
-     * @param string  $prods
-     * @param Product $product
+     * @param string|null $prods
+     * @param Product     $product
      * @return void
      */
-    private function syncProduitsAssocies(string $prods, Product $product)
+    private function syncProduitsAssocies(string $prods = null, Product $product)
     {
         if (!empty($prods)) {
             $productIds = explode(",", $prods);