diff --git a/app/Actions/Pages/UpdatePage.php b/app/Actions/Pages/UpdatePage.php new file mode 100644 index 00000000..0eec0af7 --- /dev/null +++ b/app/Actions/Pages/UpdatePage.php @@ -0,0 +1,36 @@ + + */ +final class UpdatePage implements Action +{ + /** + * @param \App\Actions\Pages\UpdatePageInput $input + */ + #[\Override] + public function __invoke(ActionInput $input): Page + { + Assert::isInstanceOf($input, UpdatePageInput::class); + + $page = $input->page; + $page->fill([ + 'seo_title' => $input->seo->title, + 'seo_description' => $input->seo->description, + 'title' => $input->title, + 'content' => $input->content, + ]); + $page->saveOrFail(); + + return $page; + } +} diff --git a/app/Actions/Pages/UpdatePageInput.php b/app/Actions/Pages/UpdatePageInput.php new file mode 100644 index 00000000..15a88286 --- /dev/null +++ b/app/Actions/Pages/UpdatePageInput.php @@ -0,0 +1,27 @@ +content)); + + if ($this->title !== null) { + Assert::stringNotEmpty(trim($this->title)); + Assert::maxLength($this->title, 255); + } + } +} diff --git a/app/Dto/PageDto.php b/app/Dto/PageDto.php new file mode 100644 index 00000000..cfe0e447 --- /dev/null +++ b/app/Dto/PageDto.php @@ -0,0 +1,78 @@ + + */ +final readonly class PageDto implements Arrayable, UrlRoutable +{ + public function __construct( + public int $id, + public StaticPageSlug $slug, + public string $seo_title, + public string $seo_description, + public ?string $title, + public string $content, + ) { + } + + public static function fromModel(Page $page): self + { + return new self( + id: $page->id, + slug: $page->slug, + seo_title: $page->seo_title, + seo_description: $page->seo_description, + title: $page->title, + content: $page->content, + ); + } + + #[\Override] + public function getRouteKey(): mixed + { + return $this->slug->value; + } + + #[\Override] + public function getRouteKeyName(): string + { + return 'slug'; + } + + #[\Override] + public function resolveRouteBinding($value, $field = null): mixed + { + return null; + } + + #[\Override] + public function resolveChildRouteBinding($childType, $value, $field): mixed + { + return null; + } + + /** + * @return array{id: int, slug: StaticPageSlug, seo_title: string, seo_description: string, title: string|null, content: string} + */ + #[\Override] + public function toArray(): array + { + return [ + 'id' => $this->id, + 'slug' => $this->slug, + 'seo_title' => $this->seo_title, + 'seo_description' => $this->seo_description, + 'title' => $this->title, + 'content' => $this->content, + ]; + } +} diff --git a/app/Http/Controllers/Bo/PageController.php b/app/Http/Controllers/Bo/PageController.php index 95cbadbf..946136a2 100644 --- a/app/Http/Controllers/Bo/PageController.php +++ b/app/Http/Controllers/Bo/PageController.php @@ -4,43 +4,54 @@ declare(strict_types=1); namespace App\Http\Controllers\Bo; +use App\Actions\Pages\UpdatePage; +use App\Actions\Pages\UpdatePageInput; +use App\Contracts\ActionExecutor; +use App\Dto\PageDto; use App\Http\Controllers\Controller; use App\Http\Requests\Bo\Pages\UpdatePageRequest as PagesUpdatePageRequest; use App\Models\Page; +use Domain\Models\ValueObjects\SeoMetadata; use Illuminate\Contracts\View\View; use Illuminate\Http\RedirectResponse; -use Illuminate\Support\Facades\DB; use Illuminate\Support\Str; class PageController extends Controller { + public function __construct( + private readonly ActionExecutor $executor, + ) { + } + public function edit(Page $page): View { $this->authorize('update', $page); - return view('bo.pages.edit', compact('page')); + return view('bo.pages.edit', [ + 'page' => PageDto::fromModel($page), + ]); } - public function update(PagesUpdatePageRequest $request, Page $page): RedirectResponse + public function update(PagesUpdatePageRequest $request, Page $page, UpdatePage $action): RedirectResponse { $this->authorize('update', $page); - return DB::transaction(function () use ($request, $page) { - $page->fill($request->only( - $page->getFillable() - )); + $this->executor->execute( + $action, + new UpdatePageInput( + page: $page, + seo: new SeoMetadata( + title: $request->string('seo_title')->value(), + description: $request->string('seo_description')->value(), + ), + title: $request->filled('title') ? $request->string('title')->value() : null, + content: $request->string('content')->value(), + ), + ); - if ($page->saveOrFail()) { - return to_route('bo.pages.edit', $page->slug->value()) - ->with('success', trans('crud.messages.has_been_updated', [ - 'model' => Str::ucfirst(trans_choice('models.classes.pages', 1)), - ])); - } - - return to_route('bo.pages.edit', $page->slug->value()) - ->with('error', trans('crud.messages.cannot_be_updated', [ - 'model' => Str::ucfirst(trans_choice('models.classes.pages', 1)), - ])); - }); + return to_route('bo.pages.edit', $page->slug->value()) + ->with('success', trans('crud.messages.has_been_updated', [ + 'model' => Str::ucfirst(trans_choice('models.classes.pages', 1)), + ])); } } diff --git a/app/Policies/Backend/PagePolicy.php b/app/Policies/Backend/PagePolicy.php index 4f2074b0..3179a448 100644 --- a/app/Policies/Backend/PagePolicy.php +++ b/app/Policies/Backend/PagePolicy.php @@ -4,6 +4,7 @@ declare(strict_types=1); namespace App\Policies\Backend; +use App\Dto\PageDto; use App\Models\Customer; use App\Models\Page; use App\Models\User; @@ -11,7 +12,7 @@ use Domain\Enums\UserRole; class PagePolicy { - public function update(User | Customer $user, Page $_): bool + public function update(User | Customer $user, Page | PageDto $_): bool { if ($user instanceof Customer) { return false; diff --git a/app/Providers/AuthServiceProvider.php b/app/Providers/AuthServiceProvider.php index 2f18b38c..4c2e4450 100644 --- a/app/Providers/AuthServiceProvider.php +++ b/app/Providers/AuthServiceProvider.php @@ -5,9 +5,11 @@ declare(strict_types=1); namespace App\Providers; use App\Dto\FaqDto; +use App\Dto\PageDto; use App\Dto\TagDto; use App\Models\Customer; use App\Policies\Backend\FaqPolicy; +use App\Policies\Backend\PagePolicy; use App\Policies\Backend\TagPolicy; use App\Policies\Frontend\BasketPolicy; use App\Services\CrmService; @@ -33,6 +35,7 @@ class AuthServiceProvider extends ServiceProvider // * Policies Exceptions BasketProduct::class => BasketPolicy::class, FaqDto::class => FaqPolicy::class, + PageDto::class => PagePolicy::class, TagDto::class => TagPolicy::class, ]; diff --git a/app/Queries/Pages/GetPageBySlugQuery.php b/app/Queries/Pages/GetPageBySlugQuery.php new file mode 100644 index 00000000..4d453516 --- /dev/null +++ b/app/Queries/Pages/GetPageBySlugQuery.php @@ -0,0 +1,28 @@ + + */ +final readonly class GetPageBySlugQuery implements Query +{ + public function execute(StaticPageSlug | string $slug): PageDto + { + $slugValue = $slug instanceof StaticPageSlug ? $slug->value : $slug; + + /** @var \App\Models\Page $page */ + $page = Page::query() + ->where('slug', $slugValue) + ->firstOrFail(); + + return PageDto::fromModel($page); + } +} diff --git a/domain/Models/ValueObjects/SeoMetadata.php b/domain/Models/ValueObjects/SeoMetadata.php new file mode 100644 index 00000000..2e7cf6c7 --- /dev/null +++ b/domain/Models/ValueObjects/SeoMetadata.php @@ -0,0 +1,20 @@ +title)); + Assert::maxLength($this->title, 255); + Assert::stringNotEmpty(trim($this->description)); + Assert::maxLength($this->description, 500); + } +} diff --git a/resources/views/bo/layouts/nav-top.blade.php b/resources/views/bo/layouts/nav-top.blade.php index 9005374e..715f1752 100644 --- a/resources/views/bo/layouts/nav-top.blade.php +++ b/resources/views/bo/layouts/nav-top.blade.php @@ -1,5 +1,6 @@
'; + + // WHEN + $input = new UpdatePageInput( + page: $page, + seo: $seo, + title: $title, + content: $content, + ); + + // THEN + expect($input->page)->toBe($page) + ->and($input->seo)->toBe($seo) + ->and($input->title)->toBe($title) + ->and($input->content)->toBe($content); + }); + + it('allows null title', function (): void { + // GIVEN + $page = new Page(); + $seo = new SeoMetadata('Titre SEO valide', 'Description SEO valide'); + $content = 'Contenu HTML
'; + + // WHEN + $input = new UpdatePageInput( + page: $page, + seo: $seo, + title: null, + content: $content, + ); + + // THEN + expect($input->title)->toBeNull(); + }); + + it('throws when title is empty string', function (): void { + // GIVEN + $page = new Page(); + $seo = new SeoMetadata('Titre SEO valide', 'Description SEO valide'); + + // WHEN + expect(fn () => new UpdatePageInput( + page: $page, + seo: $seo, + title: ' ', + content: 'Contenu
', + )) + // THEN + ->toThrow(\InvalidArgumentException::class); + }); + + it('throws when title exceeds 255 characters', function (): void { + // GIVEN + $page = new Page(); + $seo = new SeoMetadata('Titre SEO valide', 'Description SEO valide'); + $longTitle = str_repeat('a', 256); + + // WHEN + expect(fn () => new UpdatePageInput( + page: $page, + seo: $seo, + title: $longTitle, + content: 'Contenu
', + )) + // THEN + ->toThrow(\InvalidArgumentException::class); + }); + + it('throws when content is empty', function (): void { + // GIVEN + $page = new Page(); + $seo = new SeoMetadata('Titre SEO valide', 'Description SEO valide'); + + // WHEN + expect(fn () => new UpdatePageInput( + page: $page, + seo: $seo, + title: 'Titre', + content: ' ', + )) + // THEN + ->toThrow(\InvalidArgumentException::class); + }); +}); diff --git a/tests/Unit/App/Dto/PageDtoTest.php b/tests/Unit/App/Dto/PageDtoTest.php new file mode 100644 index 00000000..3cdf6b9f --- /dev/null +++ b/tests/Unit/App/Dto/PageDtoTest.php @@ -0,0 +1,43 @@ +id = 1; + $page->slug = StaticPageSlug::FAQ; + $page->seo_title = 'FAQ SEO Title'; + $page->seo_description = 'FAQ SEO Description'; + $page->title = 'Foire aux questions'; + $page->content = 'Questions et réponses
'; + + // WHEN + $dto = PageDto::fromModel($page); + + // THEN + expect($dto->id)->toBe(1) + ->and($dto->slug)->toBe(StaticPageSlug::FAQ) + ->and($dto->seo_title)->toBe('FAQ SEO Title') + ->and($dto->seo_description)->toBe('FAQ SEO Description') + ->and($dto->title)->toBe('Foire aux questions') + ->and($dto->content)->toBe('Questions et réponses
') + ->and($dto->getRouteKey())->toBe('faq') + ->and($dto->getRouteKeyName())->toBe('slug') + ->and($dto->resolveRouteBinding('faq'))->toBeNull() + ->and($dto->resolveChildRouteBinding('child', 'val', 'field'))->toBeNull() + ->and($dto->toArray())->toBe([ + 'id' => 1, + 'slug' => StaticPageSlug::FAQ, + 'seo_title' => 'FAQ SEO Title', + 'seo_description' => 'FAQ SEO Description', + 'title' => 'Foire aux questions', + 'content' => 'Questions et réponses
', + ]); + }); +}); diff --git a/tests/Unit/App/Policies/Backend/PagePolicyTest.php b/tests/Unit/App/Policies/Backend/PagePolicyTest.php index b5c8b2b1..30b755f7 100644 --- a/tests/Unit/App/Policies/Backend/PagePolicyTest.php +++ b/tests/Unit/App/Policies/Backend/PagePolicyTest.php @@ -2,10 +2,12 @@ declare(strict_types=1); +use App\Dto\PageDto; use App\Models\Customer; use App\Models\Page; use App\Models\User; use App\Policies\Backend\PagePolicy; +use Domain\Enums\StaticPageSlug; use Domain\Enums\UserRole; describe('PagePolicy', function () { @@ -35,4 +37,25 @@ describe('PagePolicy', function () { // THEN expect($result)->toBeTrue(); }); + + test('update returns true for admin user with PageDto', function () { + // GIVEN + $user = new User(); + $user->role = UserRole::Admin; + $policy = new PagePolicy(); + $page = new Page(); + $page->id = 1; + $page->slug = StaticPageSlug::FAQ; + $page->seo_title = 'SEO Title'; + $page->seo_description = 'SEO Description'; + $page->title = 'Title'; + $page->content = 'Content'; + $dto = PageDto::fromModel($page); + + // WHEN + $result = $policy->update($user, $dto); + + // THEN + expect($result)->toBeTrue(); + }); }); diff --git a/tests/Unit/Domain/Models/ValueObjects/SeoMetadataTest.php b/tests/Unit/Domain/Models/ValueObjects/SeoMetadataTest.php new file mode 100644 index 00000000..241d7c7e --- /dev/null +++ b/tests/Unit/Domain/Models/ValueObjects/SeoMetadataTest.php @@ -0,0 +1,64 @@ +title)->toBe($title) + ->and($seo->description)->toBe($description); + }); + + it('throws when title is empty', function (): void { + // GIVEN + $emptyTitle = ' '; + $description = 'Description valide'; + + // WHEN + expect(fn () => new SeoMetadata(title: $emptyTitle, description: $description)) + // THEN + ->toThrow(\InvalidArgumentException::class); + }); + + it('throws when title exceeds 255 characters', function (): void { + // GIVEN + $tooLongTitle = str_repeat('a', 256); + $description = 'Description valide'; + + // WHEN + expect(fn () => new SeoMetadata(title: $tooLongTitle, description: $description)) + // THEN + ->toThrow(\InvalidArgumentException::class); + }); + + it('throws when description is empty', function (): void { + // GIVEN + $title = 'Titre valide'; + $emptyDescription = ' '; + + // WHEN + expect(fn () => new SeoMetadata(title: $title, description: $emptyDescription)) + // THEN + ->toThrow(\InvalidArgumentException::class); + }); + + it('throws when description exceeds 500 characters', function (): void { + // GIVEN + $title = 'Titre valide'; + $tooLongDescription = str_repeat('a', 501); + + // WHEN + expect(fn () => new SeoMetadata(title: $title, description: $tooLongDescription)) + // THEN + ->toThrow(\InvalidArgumentException::class); + }); +});