From 4bbea5d28508eeb8d3dc543170f79c137723ff7f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Munsch?= Date: Mon, 16 Nov 2026 00:53:36 +0100 Subject: [PATCH] fix(bo): check proper model policy in ranges and pickup exceptions index views --- .../bo/pickup-exceptions/index.blade.php | 2 +- resources/views/bo/ranges/index.blade.php | 2 +- .../Bo/PickupExceptionsControllerTest.php | 45 +++++++++++++++++++ .../Controllers/Bo/RangesControllerTest.php | 43 ++++++++++++++++++ 4 files changed, 90 insertions(+), 2 deletions(-) diff --git a/resources/views/bo/pickup-exceptions/index.blade.php b/resources/views/bo/pickup-exceptions/index.blade.php index 7628983f..57ce7f0c 100644 --- a/resources/views/bo/pickup-exceptions/index.blade.php +++ b/resources/views/bo/pickup-exceptions/index.blade.php @@ -19,7 +19,7 @@
- @can('create', \App\Models\Slide::class) + @can('create', \App\Models\PickupException::class) diff --git a/resources/views/bo/ranges/index.blade.php b/resources/views/bo/ranges/index.blade.php index 288a4256..9192ad15 100644 --- a/resources/views/bo/ranges/index.blade.php +++ b/resources/views/bo/ranges/index.blade.php @@ -15,7 +15,7 @@

- @can('create', \App\Models\Tag::class) + @can('create', \App\Models\Range::class) diff --git a/tests/Feature/App/Http/Controllers/Bo/PickupExceptionsControllerTest.php b/tests/Feature/App/Http/Controllers/Bo/PickupExceptionsControllerTest.php index bc70e6a1..f3bd9ac8 100644 --- a/tests/Feature/App/Http/Controllers/Bo/PickupExceptionsControllerTest.php +++ b/tests/Feature/App/Http/Controllers/Bo/PickupExceptionsControllerTest.php @@ -3,9 +3,13 @@ declare(strict_types=1); use App\Models\PickupException; +use App\Models\Slide; use App\Models\User; use Domain\Enums\RepeatFrequency; use Domain\Enums\UserRole; +use Illuminate\Support\Facades\Gate; + +use function Pest\Laravel\get; describe('PickupExceptionsController', function () { beforeEach(function () { @@ -108,4 +112,45 @@ describe('PickupExceptionsController', function () { expect(PickupException::query()->find($pickupException->id))->toBeNull(); $response->assertRedirect('/bo/pickup-exceptions'); }); + + it('checks PickupExceptionPolicy create permission instead of SlidePolicy on index', function (): void { + // GIVEN + $deniedSlidePolicy = new class () + { + public function create(): bool + { + return false; + } + }; + Gate::policy(Slide::class, $deniedSlidePolicy::class); + + // WHEN + $responseWhenSlideCreateDenied = get(route('bo.pickup-exceptions.index')); + + // THEN + $responseWhenSlideCreateDenied->assertOk(); + $responseWhenSlideCreateDenied->assertSee(route('bo.pickup-exceptions.create')); + + // GIVEN + $pickupExceptionPolicyWithoutCreate = new class () + { + public function viewAny(): bool + { + return true; + } + + public function create(): bool + { + return false; + } + }; + Gate::policy(PickupException::class, $pickupExceptionPolicyWithoutCreate::class); + + // WHEN + $responseWhenPickupExceptionCreateDenied = get(route('bo.pickup-exceptions.index')); + + // THEN + $responseWhenPickupExceptionCreateDenied->assertOk(); + $responseWhenPickupExceptionCreateDenied->assertDontSee(route('bo.pickup-exceptions.create')); + }); }); diff --git a/tests/Feature/App/Http/Controllers/Bo/RangesControllerTest.php b/tests/Feature/App/Http/Controllers/Bo/RangesControllerTest.php index e8babcce..82d92b58 100644 --- a/tests/Feature/App/Http/Controllers/Bo/RangesControllerTest.php +++ b/tests/Feature/App/Http/Controllers/Bo/RangesControllerTest.php @@ -4,6 +4,7 @@ declare(strict_types=1); use App\Http\Requests\Bo\Ranges\StoreRangeRequest; use App\Models\Range; +use App\Models\Tag; use App\Models\User; use Domain\Enums\UserRole; use Illuminate\Foundation\Testing\RefreshDatabase; @@ -12,6 +13,7 @@ use Illuminate\Support\Facades\Gate; use Uwil\Storage\Contracts\StorageService; use Uwil\Storage\Lib\ValueObjects\StorageFilePath; +use function Pest\Laravel\get; use function Pest\Laravel\patch; uses(RefreshDatabase::class); @@ -189,6 +191,47 @@ describe('RangesController', function () { expect($range->status)->toBeTrue(); }); + it('checks RangePolicy create permission instead of TagPolicy on index', function (): void { + // GIVEN + $deniedTagPolicy = new class () + { + public function create(): bool + { + return false; + } + }; + Gate::policy(Tag::class, $deniedTagPolicy::class); + + // WHEN + $responseWhenTagCreateDenied = get(route('bo.ranges.index')); + + // THEN + $responseWhenTagCreateDenied->assertOk(); + $responseWhenTagCreateDenied->assertSee(route('bo.ranges.create')); + + // GIVEN + $rangePolicyWithoutCreate = new class () + { + public function viewAny(): bool + { + return true; + } + + public function create(): bool + { + return false; + } + }; + Gate::policy(Range::class, $rangePolicyWithoutCreate::class); + + // WHEN + $responseWhenRangeCreateDenied = get(route('bo.ranges.index')); + + // THEN + $responseWhenRangeCreateDenied->assertOk(); + $responseWhenRangeCreateDenied->assertDontSee(route('bo.ranges.create')); + }); + it('forbids changeOrder when update policy denies access', function (): void { // GIVEN $range = new Range();