From b62e15efc2848c711ee3e97c1917c5b00df08824 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Munsch?= Date: Sun, 15 Nov 2026 19:47:32 +0100 Subject: [PATCH] feat(product): add GetProductIncoForEditQuery and related classes Implement GetProductIncoForEditQuery, its input and output classes to handle product INCO data retrieval. Update ProductIncosController to utilize the new query for editing product INCOs. Add tests for GetProductIncoForEditQuery to ensure correct behavior. --- .../GetProductIncoForEditQuery.php | 46 +++++++++ .../GetProductIncoForEditQueryInput.php | 16 +++ .../GetProductIncoForEditQueryOutput.php | 17 ++++ .../Controllers/Bo/ProductIncosController.php | 23 ++--- .../GetProductIncoForEditQueryTest.php | 97 +++++++++++++++++++ 5 files changed, 185 insertions(+), 14 deletions(-) create mode 100644 app/Cqs/Queries/ProductIncos/GetProductIncoForEditQuery.php create mode 100644 app/Cqs/Queries/ProductIncos/GetProductIncoForEditQueryInput.php create mode 100644 app/Cqs/Queries/ProductIncos/GetProductIncoForEditQueryOutput.php create mode 100644 tests/Integration/WithApp/App/Queries/ProductIncos/GetProductIncoForEditQueryTest.php diff --git a/app/Cqs/Queries/ProductIncos/GetProductIncoForEditQuery.php b/app/Cqs/Queries/ProductIncos/GetProductIncoForEditQuery.php new file mode 100644 index 00000000..f5545834 --- /dev/null +++ b/app/Cqs/Queries/ProductIncos/GetProductIncoForEditQuery.php @@ -0,0 +1,46 @@ + + */ +final readonly class GetProductIncoForEditQuery implements Query +{ + public function __construct( + private ProductDtoAssemblerService $assembler, + ) { + } + + /** + * @param \App\Cqs\Queries\ProductIncos\GetProductIncoForEditQueryInput $input + */ + #[\Override] + public function __invoke(QueryInput $input): GetProductIncoForEditQueryOutput + { + Assert::isInstanceOf($input, GetProductIncoForEditQueryInput::class); + + $product = Product::query() + ->with(['inco', 'validDiscount', 'range']) + ->where('id', $input->productId->value->toString()) + ->firstOrFail(); + + return new GetProductIncoForEditQueryOutput( + product: $this->assembler->toDto($product), + inco: $product->inco instanceof ProductInco ? ProductIncoDto::fromModel($product->inco) : null, + ); + } +} diff --git a/app/Cqs/Queries/ProductIncos/GetProductIncoForEditQueryInput.php b/app/Cqs/Queries/ProductIncos/GetProductIncoForEditQueryInput.php new file mode 100644 index 00000000..8471abc8 --- /dev/null +++ b/app/Cqs/Queries/ProductIncos/GetProductIncoForEditQueryInput.php @@ -0,0 +1,16 @@ +with('success', __('The INCO sheet has been successfully synchronized from Arcadia.')); } - public function create(Product $product, ProductDtoAssemblerService $assembler): View - { - return $this->edit($product, $assembler); - } - - public function edit(Product $product, ProductDtoAssemblerService $assembler, ?ProductInco $inco = null): View + public function edit(Product $product, GetProductIncoForEditQuery $query): View { $this->authorize('associateInco', $product); - $productDto = $assembler->toDto($product); - $incoModel = $inco ?? $product->inco; - $incoDto = $incoModel instanceof ProductInco ? ProductIncoDto::fromModel($incoModel) : null; + $output = $this->executor->execute( + $query, + new GetProductIncoForEditQueryInput($product->getId()), + ); return view('bo.product-incos.edit', [ - 'product' => $productDto, - 'inco' => $incoDto, + 'product' => $output->product, + 'inco' => $output->inco, ]); } } diff --git a/tests/Integration/WithApp/App/Queries/ProductIncos/GetProductIncoForEditQueryTest.php b/tests/Integration/WithApp/App/Queries/ProductIncos/GetProductIncoForEditQueryTest.php new file mode 100644 index 00000000..482526b9 --- /dev/null +++ b/tests/Integration/WithApp/App/Queries/ProductIncos/GetProductIncoForEditQueryTest.php @@ -0,0 +1,97 @@ +name = 'Gamme ' . uniqid(); + $range->status = true; + $range->order = random_int(1, 9999); + $range->picture_alt = 'alt'; + $range->picture_title = 'title'; + $range->saveOrFail(); + + $product = new Product([ + 'range_id' => $range->id, + 'name' => 'Produit ' . uniqid(), + 'brand' => ProductBrand::loue, + 'invoicing_unit' => InvoicingUnit::PCE, + 'sell_unit' => SellUnit::PCE, + 'order_unit' => OrderUnit::PCE, + 'tax_rate' => TaxRate::TVA_20, + 'description' => 'Description test', + 'status' => true, + ]); + $product->id = Uuid::uuid7()->toString(); + $product->order = random_int(1, 999999); + $product->price = Money::EUR(1000); + $product->short_description = 'Court'; + $product->picture_alt = 'alt'; + $product->picture_title = 'title'; + $product->picture_large_alt = 'alt'; + $product->picture_large_title = 'title'; + $product->saveOrFail(); + + return $product; +} + +describe('GetProductIncoForEditQuery', function (): void { + it('returns immutable ProductDto and null inco when product has no INCO sheet', function (): void { + // GIVEN + $product = createTestProductForIncoQuery(); + $query = new GetProductIncoForEditQuery( + new ProductDtoAssemblerService(new EloquentProductRepository()), + ); + + // WHEN + $output = $query(new GetProductIncoForEditQueryInput($product->getId())); + + // THEN + expect($output)->toBeInstanceOf(GetProductIncoForEditQueryOutput::class) + ->and($output->product)->toBeInstanceOf(ProductDto::class) + ->and($output->product->id)->toBe($product->id) + ->and($output->inco)->toBeNull(); + }); + + it('returns immutable ProductDto and ProductIncoDto when product has an INCO sheet', function (): void { + // GIVEN + $product = createTestProductForIncoQuery(); + $inco = new ProductInco(); + $inco->no_art = 12345; + $inco->product()->associate($product); + $inco->saveOrFail(); + + $query = new GetProductIncoForEditQuery( + new ProductDtoAssemblerService(new EloquentProductRepository()), + ); + + // WHEN + $output = $query(new GetProductIncoForEditQueryInput($product->getId())); + + // THEN + expect($output)->toBeInstanceOf(GetProductIncoForEditQueryOutput::class) + ->and($output->product)->toBeInstanceOf(ProductDto::class) + ->and($output->inco)->toBeInstanceOf(ProductIncoDto::class) + ->and($output->inco?->id)->toBe($inco->id) + ->and($output->inco?->no_art)->toBe(12345); + }); +});