Commit graph

118 commits

Author SHA1 Message Date
Jérémy Munsch
aba49edaee
chore(config,tests): disable local disk serving route and freeze time in ShopperTest 2026-11-17 12:32:21 +01:00
Jérémy Munsch
d9edcd7f6b
test(uuid): migrate test suite to UuidHelper and add missing describe blocks 2026-11-17 12:15:39 +01:00
Jérémy Munsch
ad2c8f631b
feat(shared): encapsulate UUID generation and parsing in UuidHelper 2026-11-17 12:15:28 +01:00
Jérémy Munsch
d2a7afc020
Merge branch 'develop' into to-pvc-less
# Conflicts:
#	app/Services/EmployeeCsvReaderService.php
#	tests/Feature/App/Console/Commands/UpsertEmployeesFormFileTest.php
#	tests/Unit/App/Services/EmployeeCsvReaderServiceTest.php
2026-11-17 10:36:59 +01:00
Jérémy Munsch
3a1b34602c
fix(ImportEmployees): include matricule in error messages
fix(UpsertEmployeesFormFile): return failure on import errors

test(UpsertEmployeesFormFileTest): add tests for CSV import error handling

test(EmployeeCsvReaderServiceTest): validate error messages for invalid headers
2026-11-17 10:32:25 +01:00
Jérémy Munsch
df885e3805
test(EmployeeCsvReaderService): add tests for CSV import with different encodings
Added tests to verify employee import functionality from comma-delimited Windows-1252 and UTF-16LE BOM tab-delimited CSV files.
2026-11-17 10:25:21 +01:00
Jérémy Munsch
b6c5660d5e
feat(EmployeeCsvReaderService): refactor CSV reader creation
Updated the importEmployeesFromCsv method to use a dedicated createCsvReader method for better encoding handling and improved readability.
2026-11-17 09:49:03 +01:00
Jérémy Munsch
101d0ff018
feat(EmployeeCsvReaderService): refactor CSV reader creation
Updated the importEmployeesFromCsv method to use a dedicated createCsvReader method for better encoding handling and improved readability.
2026-11-17 09:46:05 +01:00
Jérémy Munsch
1085a2d4db
test(enums): add enum fixtures for testing BaseEnum functionality
- Introduced IntStatusFixture, StringStatusFixture, and MissingLabelFixture for comprehensive testing of enum behavior.
2026-11-17 09:37:58 +01:00
Jérémy Munsch
7a701328f9
test(orders): verify selected HTML option, failed status filter, and all OrderStatus cases 2026-11-16 20:39:50 +01:00
Jérémy Munsch
758605be09
refactor(domain,orders): convert OrderStatus enum to lowercase string 2026-11-16 20:31:25 +01:00
Jérémy Munsch
3b24436263
feat(stats,orders): track tunnel attempts in DB to preserve waiting stats 2026-11-16 20:19:31 +01:00
Jérémy Munsch
c58a2c8b23
feat(orders): add checkout lock, FAIL/PENDING isolation, and stale pending expiration 2026-11-16 20:05:35 +01:00
Jérémy Munsch
53f49fea9c
refactor(domain,infra): isolate PENDING/FAILED order states and add lockForUpdate 2026-11-16 19:57:06 +01:00
Jérémy Munsch
757f9aebaa
fix(casts): treat empty string as null in FilePathCast 2026-11-16 18:34:09 +01:00
Jérémy Munsch
b4384c00a7
chore(lint): resolve remaining PHPCS warnings across domain, infra, shared, and unit tests 2026-11-16 16:34:21 +01:00
Jérémy Munsch
14fd20c303
test(quality): resolve PHPStan level 10 errors in Feature tests and wrap long test lines 2026-11-16 16:29:17 +01:00
Jérémy Munsch
1b44f9d178
test(quality): resolve all PHPStan level 10 errors in Unit and Integration tests 2026-11-16 16:13:14 +01:00
Jérémy Munsch
2db00301f4
test(shared): add pure unit test suites across Helpers, Enums, Filesystem, Pagination, and ValueObjects 2026-11-16 16:01:08 +01:00
Jérémy Munsch
c9d53f43c0
test(clock): add global clock reset and freeze time across 22 test files 2026-11-16 15:49:48 +01:00
Jérémy Munsch
c083d74032
test(phpstan): remove all 145 redundant Pest expectations 2026-11-16 15:43:10 +01:00
Jérémy Munsch
7ad5acebd3
test(requests): overhaul FO request tests and lock Architecture rules 2026-11-16 15:31:41 +01:00
Jérémy Munsch
1c304b78b2
test(decouple): remove expect(true)->toBeTrue() and move ProductPolicy INCO checks to WithApp 2026-11-16 15:12:42 +01:00
Jérémy Munsch
4f2b7ba0c0
test(tests): update ArcadiaIncoServiceTest for null safety
Refactor assertions to use null-safe operator and simplify instantiation of IncoNutriscore.
2026-11-16 15:07:53 +01:00
Jérémy Munsch
8a6b1442e6
test(tests): remove Reflection attribute/constructor hacks and pass-through InitializeOrderTunnel (lot 4A) 2026-11-16 15:01:17 +01:00
Jérémy Munsch
a87e5a0c94
test(tests): add unit tests for Pagination value object 2026-11-16 14:19:02 +01:00
Jérémy Munsch
588a93cbcf
test(tests): add PSR-4 namespaces to Unit test files 2026-11-16 14:18:42 +01:00
Jérémy Munsch
3f4856efa2
test(tests): move Laravel-bound tests out of Unit and group Unit Cqs tests (lot 3B) 2026-11-16 13:02:15 +01:00
Jérémy Munsch
7b27f532ee
test(tests): fix PHPStan level 10 errors in OrderTunnelServiceTest and PickupSchedulingServiceTest 2026-11-16 13:00:47 +01:00
Jérémy Munsch
ec6e220138
test(tests): update Carbon usage in GetPickTimeSlotQueryTest and IcsGeneratorServiceTest
Refactor date handling to use CarbonImmutable for consistency in tests.
2026-11-16 12:54:30 +01:00
Jérémy Munsch
a2fd843398
test(tests): add unit tests for session-based basket repository
Added tests for the SessionBasketRepository to ensure correct behavior when finding, persisting, and deleting baskets in the session.
2026-11-16 12:53:27 +01:00
Jérémy Munsch
4c8280d932
test(tests): prune constructor-only DTO tests and consolidate contracts (lot 2C) 2026-11-16 12:50:19 +01:00
Jérémy Munsch
712d42ed96
test(tests): remove generic enum, exception string, and invariant-free input tests (lot 2B) 2026-11-16 12:47:36 +01:00
Jérémy Munsch
80d3478dbe
test(tests): merge unique assertions and remove strict duplicate test files (lot 2A) 2026-11-16 12:46:06 +01:00
Jérémy Munsch
875d6dd01d
test(tests): apply step 1 hygiene, clock reset, and explicit Arcadia policy skips 2026-11-16 12:39:21 +01:00
Jérémy Munsch
3d1c798c08
refactor(orders): split pending placement, non-transactional Regate SMTP export and final confirmation 2026-11-16 03:32:57 +01:00
Jérémy Munsch
3e4dfdad4e
feat(tunnel): detect basket price changes during order finalization 2026-11-16 03:10:25 +01:00
Jérémy Munsch
285f42c684
fix(shopper): evaluate employee calendar dates in Europe/Paris and document BO order cancel 2026-11-16 02:10:50 +01:00
Jérémy Munsch
92dd038cb9
fix(pickup): align scheduling on Europe/Paris cutoff and attach holidays on shop creation 2026-11-16 01:58:44 +01:00
Jérémy Munsch
550f2a11c8
fix(fo): use ProductWithPricingDto for product policy checks in FO views 2026-11-16 01:16:56 +01:00
Jérémy Munsch
0411e1d73b
refactor(datatable): require column listing resolver dependency in DataTableService 2026-11-16 01:01:33 +01:00
Jérémy Munsch
c427b60210
feat(jobs): handle shop pickup exceptions, chunking, and cache deduplication in SendMissingOrderReminderJob 2026-11-15 21:39:33 +01:00
Jérémy Munsch
3ff21bdd49
feat(orders): implement CancelOrder action with output handling
Added CancelOrder action to handle order cancellations with appropriate output responses.
2026-11-15 20:12:16 +01:00
Jérémy Munsch
6a599b9855
feat(ProductIncos): implement Associate and Sync actions with output handling
- Added AssociateProductIncoOutput and SyncProductIncoOutput classes to handle action results.
- Updated AssociateProductInco and SyncProductInco actions to return structured output instead of raw models.
- Enhanced error handling for API interactions in both actions.
- Refactored ProductIncosController to utilize new output structures for better response management.
- Introduced new enums for status handling in actions and queries.
- Added tests for new output handling and error scenarios in Associate and Sync actions.
2026-11-15 20:11:28 +01:00
Jérémy Munsch
0aa4b449b4
feat(orders): implement ApplyPickTimeSlot action and output handling
- Introduced ApplyPickTimeSlotOutput class for structured output.
- Updated ApplyPickTimeSlot action to return ApplyPickTimeSlotOutput.
- Added ApplyPickTimeSlotStatus enum for status representation.
- Modified TunnelController to handle new output structure.
- Enhanced tests for ApplyPickTimeSlot to validate new behavior.
2026-11-15 20:08:25 +01:00
Jérémy Munsch
8892a55322
feat(orders): implement CancelOrder action and output enum
Added CancelOrder action with output handling for order cancellation.
Introduced CancelOrderOutput enum to represent cancellation states.
Refactored ShopPolicy to simplify user checks in viewPickupTimeslots.
Updated tests to reflect changes in policy behavior.
2026-11-15 20:05:41 +01:00
Jérémy Munsch
4dd7cc82fe
feat(order): add InactiveShopperException handling in order finalization
- Introduced InactiveShopperException to manage inactive shopper scenarios.
- Updated FinalizeOrder and FinalizeOrderOutput to handle new exception.
- Enhanced TunnelController and tests to ensure proper redirection and error handling.
2026-11-15 19:59:17 +01:00
Jérémy Munsch
5a19f01270
test(product): add tests for orderable date boundaries
Added tests to verify behavior of canBeOrderOn method
when the date equals orderable_start and orderable_end.
2026-11-15 19:49:55 +01:00
Jérémy Munsch
0ae05e031d
feat(jobs): enhance SendMissingOrderReminderJob with ICS content generation
- Added IcsGeneratorService for generating ICS content.
- Updated MissingOrderReminderNotification to include cutoff date and ICS content.
- Refactored SendMissingOrderReminderJob to utilize new ICS generation logic.
- Introduced IcsContent value object for better ICS content handling.
- Added tests for new functionality in SendMissingOrderReminderJob and IcsGeneratorService.
2026-11-15 19:49:48 +01:00
Jérémy Munsch
c4d9c84408
feat(policy): implement customer order limit policy with config values
Added CustomerOrderLimitPolicy to manage order limits based on configuration values.
Updated tests to reflect changes in constructor parameters.
2026-11-15 19:39:35 +01:00