Commit graph

22 commits

Author SHA1 Message Date
Jérémy Munsch
d2a7afc020
Merge branch 'develop' into to-pvc-less
# Conflicts:
#	app/Services/EmployeeCsvReaderService.php
#	tests/Feature/App/Console/Commands/UpsertEmployeesFormFileTest.php
#	tests/Unit/App/Services/EmployeeCsvReaderServiceTest.php
2026-11-17 10:36:59 +01:00
Jérémy Munsch
3a1b34602c
fix(ImportEmployees): include matricule in error messages
fix(UpsertEmployeesFormFile): return failure on import errors

test(UpsertEmployeesFormFileTest): add tests for CSV import error handling

test(EmployeeCsvReaderServiceTest): validate error messages for invalid headers
2026-11-17 10:32:25 +01:00
Jérémy Munsch
df885e3805
test(EmployeeCsvReaderService): add tests for CSV import with different encodings
Added tests to verify employee import functionality from comma-delimited Windows-1252 and UTF-16LE BOM tab-delimited CSV files.
2026-11-17 10:25:21 +01:00
Jérémy Munsch
b6c5660d5e
feat(EmployeeCsvReaderService): refactor CSV reader creation
Updated the importEmployeesFromCsv method to use a dedicated createCsvReader method for better encoding handling and improved readability.
2026-11-17 09:49:03 +01:00
Jérémy Munsch
101d0ff018
feat(EmployeeCsvReaderService): refactor CSV reader creation
Updated the importEmployeesFromCsv method to use a dedicated createCsvReader method for better encoding handling and improved readability.
2026-11-17 09:46:05 +01:00
Jérémy Munsch
c083d74032
test(phpstan): remove all 145 redundant Pest expectations 2026-11-16 15:43:10 +01:00
Jérémy Munsch
4f2b7ba0c0
test(tests): update ArcadiaIncoServiceTest for null safety
Refactor assertions to use null-safe operator and simplify instantiation of IncoNutriscore.
2026-11-16 15:07:53 +01:00
Jérémy Munsch
588a93cbcf
test(tests): add PSR-4 namespaces to Unit test files 2026-11-16 14:18:42 +01:00
Jérémy Munsch
ec6e220138
test(tests): update Carbon usage in GetPickTimeSlotQueryTest and IcsGeneratorServiceTest
Refactor date handling to use CarbonImmutable for consistency in tests.
2026-11-16 12:54:30 +01:00
Jérémy Munsch
80d3478dbe
test(tests): merge unique assertions and remove strict duplicate test files (lot 2A) 2026-11-16 12:46:06 +01:00
Jérémy Munsch
875d6dd01d
test(tests): apply step 1 hygiene, clock reset, and explicit Arcadia policy skips 2026-11-16 12:39:21 +01:00
Jérémy Munsch
0ae05e031d
feat(jobs): enhance SendMissingOrderReminderJob with ICS content generation
- Added IcsGeneratorService for generating ICS content.
- Updated MissingOrderReminderNotification to include cutoff date and ICS content.
- Refactored SendMissingOrderReminderJob to utilize new ICS generation logic.
- Introduced IcsContent value object for better ICS content handling.
- Added tests for new functionality in SendMissingOrderReminderJob and IcsGeneratorService.
2026-11-15 19:49:48 +01:00
Jérémy Munsch
083357f746
test(EmployeeCsvImportLineService): fix end date format in test
Updated the expected end date format in the test to match the correct 'Y-m-d' format.
2026-11-14 08:47:52 +01:00
Jérémy Munsch
552d220b69
refactor(csv): replace Fusonic CSV reader with League CSV
Updated the CSV reading implementation to use the League CSV library, enhancing flexibility and maintainability.
Removed the EnhancedCsvReader class and adjusted the EmployeeCsvReaderService accordingly.
2026-11-14 08:25:50 +01:00
Jérémy Munsch
b2989b4967
refactor(employee): update import handling and output structure
- Replaced resource handling with SplFileObject for better readability.
- Introduced ImportEmployeesOutput class for structured results.
- Updated related services and tests to accommodate new structures.
2026-11-10 19:31:34 +01:00
Jérémy Munsch
74ab9b3041
refactor: reorganize imports across multiple controllers and jobs
This commit refactors the import statements in various controllers and jobs
to improve code organization and readability. Unused imports were removed,
and necessary imports were added to ensure proper functionality.
2026-11-10 18:15:32 +01:00
Jérémy Munsch
7a2004637d
feat(employee): implement employee import functionality
- Added EmployeesImportResults class to encapsulate import results.
- Created ImportEmployees action to handle CSV import and upsert employees.
- Introduced ImportEmployeesInput class for input validation.
- Developed EmployeeCsvReaderService for reading and parsing CSV files.
- Implemented EmployeeCsvImportLine to map CSV rows to employee data.
- Added EnhancedCsvReader for improved CSV handling.
- Updated composer.json to include fusonic/csv-reader dependency.
- Created tests for the new employee import functionality.
2026-11-10 18:08:41 +01:00
Jérémy Munsch
3de48c14fd
feat(arcadia): add ArcadiaIncoService and DTOs to fetch and preview INCO sheets via Arcadia API 2026-10-27 09:58:53 +01:00
Jérémy Munsch
e0c4b34ed8
feat(employees): implement deterministic 6-character code generation using SerialCaster
- Add kwaadpepper/serial-int-caster and SerialCasterServiceProvider
- Update CodeGenerationService to encode Matricule deterministically with length 6
- Update Code value object to support lengths between 6 and 10 with 53 non-ambiguous characters
- Add database migration to sanitize legacy ambiguous codes
- Recreate and update unit and integration tests for CodeGenerationService and Code value object
2026-10-27 09:58:46 +01:00
Jérémy Munsch
3b3997d547
feat(employees): automated sync with Arcadia API, BO settings, Shopper value objects, and pagination migration
- Implement automated synchronization of employees via Arcadia API (EmployeeSyncService, SynchronizeEmployeesWithArcadiaApi, FetchAndUpsertArcadiaEmployees)
- Add Back-Office application settings for employee sites (Setting singleton, GetSettingsQuery, UpdateSettings, SettingsController, EmployeeSitesInputComponent.vue)
- Strongly type Employee attributes using Domain Value Objects (ShopperEstablishmentCode, ShopperSiteCode, ShopperServiceCode) and Eloquent Casts
- Migrate pagination from Domain to Shared\Pagination namespace across queries and inputs
- Remove legacy and dead CSV employee import/export code
- Restore Domain\Ports\Services\CsvGenerator interface for Regate order generation
- Add comprehensive Pest unit, integration, and feature test coverage
2026-10-27 09:58:44 +01:00
Jérémy Munsch
aad9586ca9
refactor(tunnel): migrate Fo\TunnelController to CQS pattern 2026-10-27 09:58:43 +01:00
Jérémy Munsch
58af50b5c5
refactor: massive bump refactor 2026-10-27 09:58:12 +01:00