forge-joniko/ldc-crm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

add missing validation exception message on enum

Browse source
This commit is contained in:
Jérémy Munsch 2021-08-06 09:46:11 +02:00
parent f243e80ce7
commit 82b40360e6
3 changed files with 2 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
app/Enums/ApiError.php
View file

@ -44,6 +44,7 @@ class ApiError extends BaseEnum
{
return [
'modelNotFound' => trans('%s not found.'),
'validationFailed' => trans('Could not validate data.'),
'customerExists' => trans('User already registered on this site.'),
'customerNotActivated' => trans('Account is not activated.'),
'customerAlreadyActive' => trans('User already active.'),

2
app/Exceptions/Handler.php
View file

@ -112,7 +112,7 @@ class Handler extends ExceptionHandler
$request,
$e->status,
ApiError::validationFailed()->value,
sprintf('%s, %s', ApiError::validationFailed()->label, $e->getMessage()),
sprintf(ApiError::validationFailed()->label, $e->getMessage()),
['errors' => $e->errors()]
);
case ModelNotFoundException::class:

8
tests/Feature/ApiV2/CustomerTest.php
View file

@ -119,10 +119,6 @@ class CustomerTest extends ApiBase
$json = $response->decodeResponseJson();
$this->assertApiResponseStatusIs($json, ApiStatus::KO());
$this->assertEquals(ApiError::validationFailed()->value, $json->json('data.code'));
$this->assertEquals(
ApiError::validationFailed()->label . ', The given data was invalid.',
$json->json('data.message')
);
}
/**
@ -198,10 +194,6 @@ class CustomerTest extends ApiBase
$json = $response->decodeResponseJson();
$this->assertApiResponseStatusIs($json, ApiStatus::KO());
$this->assertEquals(ApiError::validationFailed()->value, $json->json('data.code'));
$this->assertEquals(
ApiError::validationFailed()->label . ', The given data was invalid.',
$json->json('data.message')
);
}
/**