From 4476166c9e68a05b3d474736587482afca27c2c5 Mon Sep 17 00:00:00 2001
From: Vincent BRIDIER <vincent.bridier@ldc.fr>
Date: Tue, 8 Aug 2023 09:32:56 +0200
Subject: [PATCH] update enum with cache

---
 app/Http/Controllers/ContactController.php | 11 ++++++++++-
 app/Providers/AppServiceProvider.php       | 16 ----------------
 resources/views/front/contact.blade.php    |  4 ++--
 3 files changed, 12 insertions(+), 19 deletions(-)

diff --git a/app/Http/Controllers/ContactController.php b/app/Http/Controllers/ContactController.php
index 1a7c18a..b4e0626 100644
--- a/app/Http/Controllers/ContactController.php
+++ b/app/Http/Controllers/ContactController.php
@@ -7,6 +7,7 @@ use App\Enums\Department;
 use App\Http\Requests\ContactFormRequest;
 use App\Mail\SendContactMail;
 use Illuminate\Support\Facades\Mail;
+use Illuminate\Support\Facades\Cache;
 
 class ContactController extends Controller
 {
@@ -17,7 +18,15 @@ class ContactController extends Controller
      */
     public function contact()
     {
-        return view('front.contact');
+        $listCountries = Cache::remember('listCountries', 86400 , function () {
+            return Country::toArray();
+        });
+
+        $listDeps = Cache::remember('listDeps', 86400 , function () {
+            return Department::toArray();
+        });
+        
+        return view('front.contact', compact('listCountries', 'listDeps'));
     }
 
     /**
diff --git a/app/Providers/AppServiceProvider.php b/app/Providers/AppServiceProvider.php
index ab6e358..f3cedc0 100644
--- a/app/Providers/AppServiceProvider.php
+++ b/app/Providers/AppServiceProvider.php
@@ -4,20 +4,9 @@ namespace App\Providers;
 
 use Illuminate\Support\Facades\URL;
 use Illuminate\Support\ServiceProvider;
-use App\Enums\Country;
-use Illuminate\Support\Facades\Cache;
 
 class AppServiceProvider extends ServiceProvider
 {
-    /**
-     * Register any application services.
-     *
-     * @return void
-     */
-    public function register()
-    {
-    }
-
     /**
      * Bootstrap any application services.
      *
@@ -34,10 +23,5 @@ class AppServiceProvider extends ServiceProvider
             }
             return request()->server('HTTP_X_FORWARDED_FOR') ?? request()->getClientIp();
         });
-
-        $listCountries = Cache::remember('listCountries', 60, function () {
-            return Country::toArray();
-        });
-        view()->share('availableCountries', $listCountries ?? Country::toArray());
     }
 }
diff --git a/resources/views/front/contact.blade.php b/resources/views/front/contact.blade.php
index 2702922..49bb1d3 100644
--- a/resources/views/front/contact.blade.php
+++ b/resources/views/front/contact.blade.php
@@ -112,7 +112,7 @@
                     <div class="country">
                         <select id="country" class="changeLength" maxlength="255" name="country" required>
                             <option value="" @if(!old('country')) selected @endif>{{ __('Sélectionnez un pays') }} *</option>
-                            @foreach($availableCountries as $country)
+                            @foreach($listCountries as $country)
                             <option value="{{ $country->value }}" @if(old('country') == $country->value) selected @endif>{{ __($country->label) }}</option>
                             @endforeach
                         </select>
@@ -120,7 +120,7 @@
                     <div class="drom">
                         <select id="departement" class="changeLength" maxlength="255" name="departement">
                             <option value="" @if(!old('departement')) selected @endif>{{ __('Sélectionnez un département') }} *</option>
-                            @foreach (\App\Enums\Department::toArray() as $departement)
+                            @foreach ($listDeps as $departement)
                             <option value="{{ $departement->value }}" @if(old('departement') === $departement->value) selected @endif>{{ __($departement->label) }}</option>
                             @endforeach
                         </select>