From 37278195e6a418c7eb7bb58cce58254cc203e45d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Munsch?= <github@jeremydev.ovh>
Date: Thu, 23 Jul 2026 14:00:24 +0200
Subject: [PATCH] fix(discount): align propertiesList with Discount::make()
 parameter order

---
 app/Http/Controllers/Bo/SettingsController.php | 8 ++++----
 app/Lib/Discount.php                           | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/app/Http/Controllers/Bo/SettingsController.php b/app/Http/Controllers/Bo/SettingsController.php
index cfde798..7c458ad 100644
--- a/app/Http/Controllers/Bo/SettingsController.php
+++ b/app/Http/Controllers/Bo/SettingsController.php
@@ -90,11 +90,11 @@ class SettingsController extends Controller
         }
         try {
             return Discount::make(
-                Arr::get($coupon, 'web_coupon_identifiant'),
-                Arr::get($coupon, 'percentage'),
-                Arr::get($coupon, 'face_value'),
-                Arr::get($coupon, 'valid_on'),
                 $picture,
+                Arr::get($coupon, 'valid_on'),
+                Arr::get($coupon, 'face_value'),
+                Arr::get($coupon, 'percentage'),
+                Arr::get($coupon, 'web_coupon_identifiant'),
             );
         } catch (\RuntimeException | \TypeError) {
             return null;
diff --git a/app/Lib/Discount.php b/app/Lib/Discount.php
index 50add06..45e0fc9 100644
--- a/app/Lib/Discount.php
+++ b/app/Lib/Discount.php
@@ -26,11 +26,11 @@ class Discount extends \stdClass implements Jsonable, Arrayable, \JsonSerializab
      * @var array<string>
      */
     private static array $propertiesList = [
-        'web_coupon_identifiant',
-        'percentage',
-        'face_value',
-        'valid_on',
         'picture',
+        'valid_on',
+        'face_value',
+        'percentage',
+        'web_coupon_identifiant',
     ];
 
     /**