From 3f6b4fe97ec9b7c2aab15d1d2babcb580e635682 Mon Sep 17 00:00:00 2001 From: Alexis Gousseau Date: Mon, 24 Nov 2025 16:01:36 +0100 Subject: [PATCH] fix: :bug: add missing rules for textarea input in dynamic field request --- app/Enums/DynamicFieldTypes.php | 2 +- .../Requests/Back/UpdateDynamicFieldRequest.php | 17 ++++++++++++++++- .../Components/DynamicPages/DynamicInputs.tsx | 1 + 3 files changed, 18 insertions(+), 2 deletions(-) diff --git a/app/Enums/DynamicFieldTypes.php b/app/Enums/DynamicFieldTypes.php index c87af55b..62aa2ab8 100644 --- a/app/Enums/DynamicFieldTypes.php +++ b/app/Enums/DynamicFieldTypes.php @@ -51,7 +51,7 @@ enum DynamicFieldTypes: int */ private const VALIDATIONS = [ self::string->name => 'required|string|between:3,255', - self::textarea->name => 'required|string|string|min:15', + self::textarea->name => 'required|string|between:3,255', self::wysiwyg->name => 'required|string|string|min:15', self::number->name => 'required|numeric|min:0', self::boolean->name => 'required|boolean', diff --git a/app/Http/Requests/Back/UpdateDynamicFieldRequest.php b/app/Http/Requests/Back/UpdateDynamicFieldRequest.php index 44891f82..e9dd6c66 100644 --- a/app/Http/Requests/Back/UpdateDynamicFieldRequest.php +++ b/app/Http/Requests/Back/UpdateDynamicFieldRequest.php @@ -57,6 +57,11 @@ abstract class UpdateDynamicFieldRequest extends FormRequest return $rules; } + /** + * Get rules from a specific input type. + * + * @return array + */ private function recursiveRules(&$input, $prefix): array { $rules = []; @@ -67,6 +72,11 @@ abstract class UpdateDynamicFieldRequest extends FormRequest $ruleKey => $this->compileValidate(DynamicFieldTypes::string->getValidation(), $input) ]); break; + case DynamicFieldTypes::textarea->value: + $rules = array_merge($rules, [ + $ruleKey => $this->compileValidate(DynamicFieldTypes::textarea->getValidation(), $input) + ]); + break; case DynamicFieldTypes::wysiwyg->value: $mergeRules = $this->compileValidate(DynamicFieldTypes::wysiwyg->getValidation(), $input); $mergeRules = collect($mergeRules) @@ -165,7 +175,12 @@ abstract class UpdateDynamicFieldRequest extends FormRequest return $attributes; } - public function recursiveAttributes(&$input, $prefix): array + /** + * Get attributes from a specific input type. + * + * @return array + */ + private function recursiveAttributes(&$input, $prefix): array { $attributes = []; $attributeKey = sprintf("%s.%s", $prefix, $input['key']); diff --git a/resources/ts/back/Components/DynamicPages/DynamicInputs.tsx b/resources/ts/back/Components/DynamicPages/DynamicInputs.tsx index 455d7735..b5855867 100644 --- a/resources/ts/back/Components/DynamicPages/DynamicInputs.tsx +++ b/resources/ts/back/Components/DynamicPages/DynamicInputs.tsx @@ -92,6 +92,7 @@ export default function DynamicInputs({ key={id} name={fieldName} label={getTrans(field.label)} + required={extractRequiredValidation(field.validation)} value={String(fieldValue)} setData={setData} parentErrors={parentErrors}