refactor max order on create

This commit is contained in:
Jérémy Munsch 2022-12-20 17:35:53 +01:00
parent f06b2aa101
commit 0632e5484f
No known key found for this signature in database
GPG key ID: 18361AF3BFEC0FEC

View file

@ -86,7 +86,7 @@ class Slider extends Model
static::creating(function (self $model) {
ToolboxHelper::assertNoInternalBoUrls('link', $model->link);
$model->picture = FileStorageHelper::storeFile($model, $model->picture);
self::setOrder($model);
$model->order = \intval(Slider::query()->max('order')) + 1;
if (!$model->status) {
$model->publish_at = null;
} else {
@ -120,21 +120,4 @@ class Slider extends Model
}
// * METHODS
/**
* Set order after the last element of the list.
*
* @param \Illuminate\Database\Eloquent\Model $model
* @return void
*/
private function setOrder(Model $model): void
{
$lastModel = Slider::select('order')->orderBy('order', 'DESC')->first();
if ($lastModel === null) {
$model->order = 1;
} else {
$model->order = $lastModel->order + 1;
}
}
}