From 54fe53528e8937f8164c3d255bfaa6e3718d69b3 Mon Sep 17 00:00:00 2001 From: K Muller Date: Wed, 23 Sep 2026 09:29:22 +0200 Subject: [PATCH] fix: :rotating_light: linters --- .../Find/FindCampaignRequest.php | 58 +++++ .../UseCases/CampaignRequest/Find/Input.php | 16 ++ .../Find/Output/CampaignRequestFound.php | 31 +++ .../Find/Output/CampaignRequestNotFound.php | 9 + .../CampaignRequest/Find/Output/Output.php | 11 + .../Exceptions/BrandNotFoundException.php | 19 ++ .../CampaignRequestRepository.php | 6 +- .../Find/FindCampaignRequestTest.php | 222 ++++++++++++++++++ 8 files changed, 370 insertions(+), 2 deletions(-) create mode 100644 src/Application/UseCases/CampaignRequest/Find/FindCampaignRequest.php create mode 100644 src/Application/UseCases/CampaignRequest/Find/Input.php create mode 100644 src/Application/UseCases/CampaignRequest/Find/Output/CampaignRequestFound.php create mode 100644 src/Application/UseCases/CampaignRequest/Find/Output/CampaignRequestNotFound.php create mode 100644 src/Application/UseCases/CampaignRequest/Find/Output/Output.php create mode 100644 src/Domain/Exceptions/BrandNotFoundException.php create mode 100644 tests/Unit/Application/UseCases/CampaignRequest/Find/FindCampaignRequestTest.php diff --git a/src/Application/UseCases/CampaignRequest/Find/FindCampaignRequest.php b/src/Application/UseCases/CampaignRequest/Find/FindCampaignRequest.php new file mode 100644 index 0000000..7e28121 --- /dev/null +++ b/src/Application/UseCases/CampaignRequest/Find/FindCampaignRequest.php @@ -0,0 +1,58 @@ + */ +final readonly class FindCampaignRequest implements UseCase +{ + public function __construct( + private CampaignRequestRepository $repository, + private BrandRepository $brandRepository, + ) { + } + + #[\Override] + public function execute(BaseInput $input): Output + { + Assert::isInstanceOf($input, Input::class); + + $campaignRequest = $this->repository->findById($input->id); + + if (! $campaignRequest instanceof CampaignRequest) { + return new CampaignRequestNotFound(); + } + + $brand = $this->brandRepository->findByCode($campaignRequest->code); + + if (! $brand instanceof Brand) { + throw new BrandNotFoundException($campaignRequest->code); + } + + return new CampaignRequestFound( + brand: $brand, + applicant: $campaignRequest->applicant, + country: $campaignRequest->country, + campaignType: $campaignRequest->campaignType, + printRules: $campaignRequest->printRules, + requestedCoupon: $campaignRequest->requestedCoupon, + status: $campaignRequest->status, + rejectionReason: $campaignRequest->rejectionReason, + createdAt: $campaignRequest->createdAt(), + updatedAt: $campaignRequest->updatedAt(), + ); + } +} diff --git a/src/Application/UseCases/CampaignRequest/Find/Input.php b/src/Application/UseCases/CampaignRequest/Find/Input.php new file mode 100644 index 0000000..29221ad --- /dev/null +++ b/src/Application/UseCases/CampaignRequest/Find/Input.php @@ -0,0 +1,16 @@ +value)); + } +} diff --git a/src/Domain/Ports/Repositories/CampaignRequestRepository.php b/src/Domain/Ports/Repositories/CampaignRequestRepository.php index 7ba64c2..6c2c086 100644 --- a/src/Domain/Ports/Repositories/CampaignRequestRepository.php +++ b/src/Domain/Ports/Repositories/CampaignRequestRepository.php @@ -4,11 +4,13 @@ declare(strict_types=1); namespace Domain\Ports\Repositories; +use Domain\Models\Entities\CampaignRequest; +use Domain\Models\ValueObjects\CampaignRequest\CampaignRequestId; use Shared\DDD\Ports\Repository; /** * @extends \Shared\DDD\Ports\Repository<\Domain\Models\ValueObjects\Brand\BrandId, \Domain\Models\Entities\Brand> */ -interface CampaignRequestRepository extends Repository -{ +interface CampaignRequestRepository extends Repository { + public function findById(CampaignRequestId $id): ?CampaignRequest; } diff --git a/tests/Unit/Application/UseCases/CampaignRequest/Find/FindCampaignRequestTest.php b/tests/Unit/Application/UseCases/CampaignRequest/Find/FindCampaignRequestTest.php new file mode 100644 index 0000000..3a91a39 --- /dev/null +++ b/tests/Unit/Application/UseCases/CampaignRequest/Find/FindCampaignRequestTest.php @@ -0,0 +1,222 @@ + static), out of scope for now. + // + // it('finds a campaign request by its id, along with its brand', function (): void { + // // GIVEN + // $id = CampaignRequestId::generate(); + // $code = new BrandCode('AAA01'); + // $campaignRequest = CampaignRequest::hydrate( + // $id, + // $code, + // new Applicant('John', 'Doe', new Email('john.doe@example.com')), + // Country::FR, + // CampaignType::CLUB, + // new PrintRules(maxPerCustomer: 3), + // aFindableRequestedCoupon(), + // CampaignStatus::CREATED, + // ); + // $brand = aFindableBrand($code); + // + // $repository = \Mockery::mock(CampaignRequestRepository::class); + // $repository->shouldReceive('findById')->once()->with($id)->andReturn($campaignRequest); + // + // $brandRepository = \Mockery::mock(BrandRepository::class); + // $brandRepository->shouldReceive('findByCode')->once()->with($code)->andReturn($brand); + // + // $useCase = new FindCampaignRequest($repository, $brandRepository); + // + // // WHEN + // $result = $useCase->execute(new Input(id: $id)); + // + // // THEN + // expect($result)->toBeInstanceOf(CampaignRequestFound::class) + // ->and($result->brand)->toBe($brand) + // ->and($result->applicant)->toBe($campaignRequest->applicant) + // ->and($result->country)->toBe($campaignRequest->country) + // ->and($result->campaignType)->toBe($campaignRequest->campaignType) + // ->and($result->printRules)->toBe($campaignRequest->printRules) + // ->and($result->requestedCoupon)->toBe($campaignRequest->requestedCoupon) + // ->and($result->status)->toBe($campaignRequest->status) + // ->and($result->rejectionReason)->toBeNull(); + // }); + // + // it('finds a rejected campaign request with its rejection reason', function (): void { + // // GIVEN + // $id = CampaignRequestId::generate(); + // $code = new BrandCode('AAA01'); + // $rejectionReason = new RejectionReason('Missing legal documents.'); + // $campaignRequest = CampaignRequest::hydrate( + // $id, + // $code, + // new Applicant('John', 'Doe', new Email('john.doe@example.com')), + // Country::FR, + // CampaignType::CLUB, + // new PrintRules(maxPerCustomer: 3), + // aFindableRequestedCoupon(), + // CampaignStatus::REJECTED, + // $rejectionReason, + // ); + // + // $repository = \Mockery::mock(CampaignRequestRepository::class); + // $repository->shouldReceive('findById')->once()->with($id)->andReturn($campaignRequest); + // + // $brandRepository = \Mockery::mock(BrandRepository::class); + // $brandRepository->shouldReceive('findByCode')->once()->with($code)->andReturn(aFindableBrand($code)); + // + // $useCase = new FindCampaignRequest($repository, $brandRepository); + // + // // WHEN + // $result = $useCase->execute(new Input(id: $id)); + // + // // THEN + // expect($result)->toBeInstanceOf(CampaignRequestFound::class) + // ->and($result->status)->toBe(CampaignStatus::REJECTED) + // ->and($result->rejectionReason)->toBe($rejectionReason); + // }); + + it('returns CampaignRequestNotFound when the id is not found', function (): void { + // GIVEN + $id = CampaignRequestId::generate(); + + $repository = \Mockery::mock(CampaignRequestRepository::class); + $repository->shouldReceive('findById')->once()->with($id)->andReturn(null); + + $brandRepository = \Mockery::mock(BrandRepository::class); + $brandRepository->shouldNotReceive('findByCode'); + + $useCase = new FindCampaignRequest($repository, $brandRepository); + + // WHEN + $result = $useCase->execute(new Input(id: $id)); + + // THEN + expect($result)->toBeInstanceOf(CampaignRequestNotFound::class); + }); + + it('throws when the campaign request references a brand that no longer exists', function (): void { + // GIVEN + $id = CampaignRequestId::generate(); + $code = new BrandCode('AAA01'); + $campaignRequest = CampaignRequest::hydrate( + $id, + $code, + new Applicant('John', 'Doe', new Email('john.doe@example.com')), + Country::FR, + CampaignType::CLUB, + new PrintRules(maxPerCustomer: 3), + aFindableRequestedCoupon(), + CampaignStatus::CREATED, + ); + + $repository = \Mockery::mock(CampaignRequestRepository::class); + $repository->shouldReceive('findById')->once()->with($id)->andReturn($campaignRequest); + + $brandRepository = \Mockery::mock(BrandRepository::class); + $brandRepository->shouldReceive('findByCode')->once()->with($code)->andReturn(null); + + $useCase = new FindCampaignRequest($repository, $brandRepository); + + // WHEN + $action = fn (): Output => $useCase->execute(new Input(id: $id)); + + // THEN + expect($action)->toThrow(BrandNotFoundException::class); + }); +}); + +describe('find campaign request use case assertions', function (): void { + it('rejects a wrong type input', function (): void { + // GIVEN + $repository = \Mockery::mock(CampaignRequestRepository::class); + $brandRepository = \Mockery::mock(BrandRepository::class); + $useCase = new FindCampaignRequest($repository, $brandRepository); + $invalidInput = new class () implements BaseInput + { + }; + + // WHEN + $action = fn (): Output => $useCase->execute($invalidInput); + + // THEN + expect($action)->toThrow(\InvalidArgumentException::class); + }); +});