From 678487aa07df4f2894af74726e0bc4451b1dcc1f Mon Sep 17 00:00:00 2001 From: Corentin Huet Date: Fri, 2 Oct 2026 12:46:02 +0200 Subject: [PATCH] refactor: :recycle: refactor coupon diffusion test --- .../Campaign/CampaignCouponTest.php | 8 +++---- .../Coupon/CouponDiffusionTest.php | 22 +++++-------------- 2 files changed, 10 insertions(+), 20 deletions(-) diff --git a/tests/Unit/Domain/Models/ValueObjects/Campaign/CampaignCouponTest.php b/tests/Unit/Domain/Models/ValueObjects/Campaign/CampaignCouponTest.php index 9938215..e700f2a 100644 --- a/tests/Unit/Domain/Models/ValueObjects/Campaign/CampaignCouponTest.php +++ b/tests/Unit/Domain/Models/ValueObjects/Campaign/CampaignCouponTest.php @@ -14,10 +14,10 @@ covers(CampaignCoupon::class); describe('campaign coupon', function (): void { beforeEach(function (): void { - $this->processingCode = new ProcessingCode('PC1'); - $this->quantity = new CouponQuantity(10); - $this->availableIn = Country::FRANCE; - $this->printRules = new PrintRules(maxPerCustomer: 3); + $this->processingCode = new ProcessingCode('PC1'); + $this->quantity = new CouponQuantity(10); + $this->availableIn = Country::FRANCE; + $this->printRules = new PrintRules(maxPerCustomer: 3); }); it('creates a valid campaign coupon', function (): void { diff --git a/tests/Unit/Domain/Models/ValueObjects/Coupon/CouponDiffusionTest.php b/tests/Unit/Domain/Models/ValueObjects/Coupon/CouponDiffusionTest.php index f9e19dc..83929ee 100644 --- a/tests/Unit/Domain/Models/ValueObjects/Coupon/CouponDiffusionTest.php +++ b/tests/Unit/Domain/Models/ValueObjects/Coupon/CouponDiffusionTest.php @@ -11,25 +11,15 @@ use DateTime; covers(CouponDiffusion::class); describe('coupon diffusion', function (): void { - it('creates a valid coupon diffusion with one period', function (): void { - // GIVEN - $period = new Period(new DateTime('2026-01-01'), new DateTime('2026-02-01')); - - // WHEN - $couponDiffusion = new CouponDiffusion($period); - - // THEN - expect($couponDiffusion->period)->toBe($period); + beforeEach(function (): void { + $this->period = new Period(new DateTime('2026-01-01'), new DateTime('2026-02-01')); }); - it('creates a valid coupon diffusion with several periods', function (): void { - // GIVEN - $period = new Period(new DateTime('2026-01-01'), new DateTime('2026-02-01')); - - // WHEN - $couponDiffusion = new CouponDiffusion($period); + it('creates a valid coupon diffusion with one period', function (): void { + // GIVEN / WHEN + $couponDiffusion = new CouponDiffusion($this->period); // THEN - expect($couponDiffusion->period)->toBe($period); + expect($couponDiffusion->period)->toBe($this->period); }); });