chore: 🚨 linters

This commit is contained in:
Noah Lancien 2026-10-30 09:19:08 +01:00
parent 491e349959
commit af4ee64fd9
3 changed files with 18 additions and 7 deletions

View file

@ -16,7 +16,6 @@ use Domain\Models\ValueObjects\Campaign\CampaignCoupon;
use Domain\Models\ValueObjects\Campaign\CampaignCouponArray;
use Domain\Models\ValueObjects\CampaignRequest\CampaignRequestStatus;
use Domain\Models\ValueObjects\CampaignRequest\CampaignRequestType;
use Domain\Models\ValueObjects\Coupon\CouponCode;
use Domain\Models\ValueObjects\Coupon\CouponDiffusion;
use Domain\Models\ValueObjects\Coupon\CouponMovement;
use Domain\Models\ValueObjects\Coupon\CouponMovementArray;
@ -59,6 +58,9 @@ final readonly class TransformCampaignRequest implements UseCase, Transactional
$createdCoupon = self::createCouponFromRequest($campaignRequest, $actorId);
if (! $createdCoupon instanceof Coupon) {
return new CouponAlreadyExists();
}
$campaignCoupon = new CampaignCoupon($createdCoupon->code, $campaignRequest->requestedCoupon->printRules);

View file

@ -80,9 +80,14 @@ describe('transform campaign request use case', function (): void {
requestedCoupon: $overrides['coupon'] ?? $requestedCoupon,
);
it('transforms a campaign request to a campaign and a coupon', function () use ($existingCampaignRequest, $campaignName): void {
it('transforms a campaign request to a campaign and a coupon', function () use (
$existingCampaignRequest,
$campaignName
): void {
// GIVEN
$campaignRequest = $existingCampaignRequest();
$processingCodes = $campaignRequest->requestedCoupon->couponProcessingCodes;
$campaignRequestRepository = \Mockery::mock(CampaignRequestRepository::class);
$campaignRequestRepository->shouldReceive('findById')->once()->with($campaignRequest->id)->andReturn($campaignRequest);
@ -90,6 +95,9 @@ describe('transform campaign request use case', function (): void {
$campaignRepository = \Mockery::mock(CampaignRepository::class);
$campaignRepository->shouldReceive('save')->once()->with(\Mockery::type(Campaign::class));
$couponRepository = \Mockery::mock(CouponRepository::class);
foreach ($processingCodes->toArray() as $processingCode) {
$couponRepository->shouldReceive('existsByProcessingCode')->with($processingCode->value)->andReturn(false);
}
$couponRepository->shouldReceive('save')->once()->with(\Mockery::type(Coupon::class));
$input = new Input($campaignRequest->id);

View file

@ -24,7 +24,6 @@ use Domain\Models\ValueObjects\Campaign\CampaignId;
use Domain\Models\ValueObjects\Campaign\CampaignName;
use Domain\Models\ValueObjects\Coupon\CouponAvailabilityCalendar;
use Domain\Models\ValueObjects\Coupon\CouponCode;
use Domain\Models\ValueObjects\Coupon\CouponName;
use Domain\Models\ValueObjects\CrmHashcode;
use Domain\Models\ValueObjects\Period;
use Domain\Models\ValueObjects\PrintableCoupon\MarketingDirectCode;
@ -47,10 +46,12 @@ describe('create coupon use case', function (): void {
$brandCode = new BrandCode('AAA01');
$campaignCode = CampaignCode::generate();
$couponCode = CouponCode::generate();
$printRules = fn (?int $maxPerCustomer = null, ?int $cooldownDays = null): ?PrintRules => ($maxPerCustomer || $cooldownDays) ? new PrintRules(
maxPerCustomer: $maxPerCustomer,
cooldownDays: $cooldownDays,
) : null;
$printRules = fn (?int $maxPerCustomer = null, ?int $cooldownDays = null): ?PrintRules => ($maxPerCustomer || $cooldownDays)
? new PrintRules(
maxPerCustomer: $maxPerCustomer,
cooldownDays: $cooldownDays,
)
: null;
$makeCoupon = fn (array $overrides = []): Coupon => CouponFactory::make(
diffusionStart: $overrides['diffusionStart'] ?? null,