forge-joniko/ldc-mesbr-app
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: 🐛 delete the assert on RejectCampaignRequest UseCase

Browse source
This commit is contained in:
K Muller 2026-09-25 12:40:57 +02:00 • committed by Corentin Huet
parent e15a372e59
commit d10b91fe48
2 changed files with 11 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/Application/UseCases/CampaignRequest/Reject/RejectCampaignRequest.php
View file

@ -8,7 +8,6 @@ use Application\UseCases\CampaignRequest\Reject\Output\CampaignRequestNotFound;
use Application\UseCases\CampaignRequest\Reject\Output\CampaignRequestRejected;
use Application\UseCases\CampaignRequest\Reject\Output\Output;
use Domain\Models\Entities\CampaignRequest;
use Domain\Models\ValueObjects\CampaignRequest\RejectionReason;
use Domain\Ports\Repositories\CampaignRequestRepository;
use Shared\DDD\UseCases\Input as BaseInput;
use Shared\DDD\UseCases\Transactional;
@ -38,9 +37,6 @@ final readonly class RejectCampaignRequest implements UseCase, Transactional
$this->repository->save($campaignRequest);
Assert::isInstanceOf($campaignRequest->rejectionReason, RejectionReason::class);
Assert::notNull($campaignRequest->updatedAt());
return new CampaignRequestRejected(
id: $campaignRequest->id(),
status: $campaignRequest->status,

17
tests/Unit/Application/UseCases/CampaignRequest/Reject/RejectCampaignRequestTest.php
View file

@ -83,7 +83,7 @@ describe('reject campaign request use case', function (): void {
$repository = \Mockery::mock(CampaignRequestRepository::class);
$repository->shouldReceive('findById')->once()->with($id)->andReturn($campaignRequest);
$repository->shouldReceive('save')->once()->with(\Mockery::on(
fn (CampaignRequest $saved): bool => $saved->status === CampaignRequestStatus::REJECTED
fn(CampaignRequest $saved): bool => $saved->status === CampaignRequestStatus::REJECTED
&& $saved->rejectionReason === $reason
&& $saved->updatedAt !== null,
));
@ -139,7 +139,7 @@ describe('reject campaign request use case', function (): void {
$useCase = new RejectCampaignRequest($repository);
// WHEN
$action = fn (): Output => $useCase->execute(
$action = fn(): Output => $useCase->execute(
new Input(id: $id, reason: new RejectionReason('Missing legal documents.'))
);
@ -149,16 +149,21 @@ describe('reject campaign request use case', function (): void {
});
describe('reject campaign request use case assertions', function (): void {
it('cannot build an input to reject a campaign request without a reason', function (): void {
// WHEN
$action = fn(): Input => new Input(id: CampaignRequestId::generate());
// THEN
expect($action)->toThrow(\ArgumentCountError::class);
});
it('rejects an input of the wrong type', function (): void {
// GIVEN
$repository = \Mockery::mock(CampaignRequestRepository::class);
$useCase = new RejectCampaignRequest($repository);
$invalidInput = new class () implements BaseInput
{
};
$invalidInput = new class() implements BaseInput {};
// WHEN
$action = fn (): Output => $useCase->execute($invalidInput);
$action = fn(): Output => $useCase->execute($invalidInput);
// THEN
expect($action)->toThrow(\InvalidArgumentException::class);