From f717533fdb95cd6f1f806c28c84f21b4c6f9ddf6 Mon Sep 17 00:00:00 2001 From: K Muller Date: Mon, 28 Sep 2026 14:32:19 +0200 Subject: [PATCH] fix: :bug: fix linters --- .../Reject/Output/CampaignRequestRejected.php | 2 +- .../CampaignRequest/Reject/RejectCampaignRequest.php | 2 +- src/Domain/Models/Entities/CampaignRequest.php | 9 +++++++++ .../Reject/RejectCampaignRequestTest.php | 12 +++++++----- 4 files changed, 18 insertions(+), 7 deletions(-) diff --git a/src/Application/UseCases/CampaignRequest/Reject/Output/CampaignRequestRejected.php b/src/Application/UseCases/CampaignRequest/Reject/Output/CampaignRequestRejected.php index ceca5c6..dcf3a78 100644 --- a/src/Application/UseCases/CampaignRequest/Reject/Output/CampaignRequestRejected.php +++ b/src/Application/UseCases/CampaignRequest/Reject/Output/CampaignRequestRejected.php @@ -14,7 +14,7 @@ final readonly class CampaignRequestRejected implements Output public CampaignRequestId $id, public CampaignRequestStatus $status, public RejectionReason $rejectionReason, - public \DateTimeInterface $updatedAt, + public ?\DateTimeInterface $updatedAt = null ) { } } diff --git a/src/Application/UseCases/CampaignRequest/Reject/RejectCampaignRequest.php b/src/Application/UseCases/CampaignRequest/Reject/RejectCampaignRequest.php index 8b8bca1..ac717f3 100644 --- a/src/Application/UseCases/CampaignRequest/Reject/RejectCampaignRequest.php +++ b/src/Application/UseCases/CampaignRequest/Reject/RejectCampaignRequest.php @@ -40,7 +40,7 @@ final readonly class RejectCampaignRequest implements UseCase, Transactional return new CampaignRequestRejected( id: $campaignRequest->id(), status: $campaignRequest->status, - rejectionReason: $campaignRequest->rejectionReason, + rejectionReason:$campaignRequest->rejectionReason(), updatedAt: $campaignRequest->updatedAt(), ); } diff --git a/src/Domain/Models/Entities/CampaignRequest.php b/src/Domain/Models/Entities/CampaignRequest.php index 68e6cfd..399ac65 100644 --- a/src/Domain/Models/Entities/CampaignRequest.php +++ b/src/Domain/Models/Entities/CampaignRequest.php @@ -104,4 +104,13 @@ final readonly class CampaignRequest implements AggregateRoot, HasTimestampIdent updatedAt: DatesHelper::now(), ); } + + public function rejectionReason(): RejectionReason + { + if (! $this->rejectionReason instanceof RejectionReason) { + throw new \DomainException('Only a rejected campaign request has a rejection reason.'); + } + + return $this->rejectionReason; + } } diff --git a/tests/Unit/Application/UseCases/CampaignRequest/Reject/RejectCampaignRequestTest.php b/tests/Unit/Application/UseCases/CampaignRequest/Reject/RejectCampaignRequestTest.php index da83261..9f7ddab 100644 --- a/tests/Unit/Application/UseCases/CampaignRequest/Reject/RejectCampaignRequestTest.php +++ b/tests/Unit/Application/UseCases/CampaignRequest/Reject/RejectCampaignRequestTest.php @@ -81,7 +81,7 @@ describe('reject campaign request use case', function (): void { $repository = \Mockery::mock(CampaignRequestRepository::class); $repository->shouldReceive('findById')->once()->with($id)->andReturn($campaignRequest); $repository->shouldReceive('save')->once()->with(\Mockery::on( - fn(CampaignRequest $saved): bool => $saved->status === CampaignRequestStatus::REJECTED + fn (CampaignRequest $saved): bool => $saved->status === CampaignRequestStatus::REJECTED && $saved->rejectionReason === $reason && $saved->updatedAt !== null, )); @@ -137,7 +137,7 @@ describe('reject campaign request use case', function (): void { $useCase = new RejectCampaignRequest($repository); // WHEN - $action = fn(): Output => $useCase->execute( + $action = fn (): Output => $useCase->execute( new Input(id: $id, reason: new RejectionReason('Missing legal documents.')) ); @@ -149,7 +149,7 @@ describe('reject campaign request use case', function (): void { describe('reject campaign request use case assertions', function (): void { it('cannot build an input to reject a campaign request without a reason', function (): void { // WHEN - $action = fn(): Input => new Input(id: CampaignRequestId::generate()); + $action = fn (): Input => new Input(id: CampaignRequestId::generate()); // THEN expect($action)->toThrow(\ArgumentCountError::class); @@ -158,10 +158,12 @@ describe('reject campaign request use case assertions', function (): void { // GIVEN $repository = \Mockery::mock(CampaignRequestRepository::class); $useCase = new RejectCampaignRequest($repository); - $invalidInput = new class() implements BaseInput {}; + $invalidInput = new class () implements BaseInput + { + }; // WHEN - $action = fn(): Output => $useCase->execute($invalidInput); + $action = fn (): Output => $useCase->execute($invalidInput); // THEN expect($action)->toThrow(\InvalidArgumentException::class);