From f80c95479c976ec21eede88bcb7e7f32ae0136af Mon Sep 17 00:00:00 2001 From: Noah Lancien Date: Tue, 20 Oct 2026 10:12:52 +0200 Subject: [PATCH] fix: :recycle: Sprint 4 feedbacks - reorganize outputs, remove useless tests ... --- .../UseCases/Brand/Create/CreateBrand.php | 11 +- .../{Output.php => Outputs/BrandCreated.php} | 4 +- .../Create/Outputs/BrandCreationFailed.php | 15 ++ .../Brand/Create/Outputs/CreateBrandError.php | 10 ++ .../Create/CreateCampaignRequest.php | 9 +- .../CampaignRequestCreated.php} | 4 +- .../Find/FindCampaignRequest.php | 6 +- .../CampaignRequest/Outputs/BrandNotFound.php | 11 ++ .../UseCases/Coupon/Create/CreateCoupon.php | 12 +- .../Outputs/CouponCodeAlreadyExists.php | 11 ++ .../{Output.php => Outputs/CouponCreated.php} | 4 +- .../UseCases/Coupon/Find/FindCoupon.php | 5 +- .../UseCases/Coupon/Outputs/BrandNotFound.php | 11 ++ .../Create/CreatePrintableCoupon.php | 53 +++--- .../Create/Outputs/CampaignNotFound.php | 11 ++ .../Create/Outputs/CampaignNotPublished.php | 11 ++ .../Create/Outputs/CouponNotAssociated.php | 11 ++ .../PrintableCouponCreated.php} | 4 +- .../List/ListPrintableCoupons.php | 9 +- .../PrintableCouponListed.php} | 5 +- .../Outputs/CouponNotFound.php | 11 ++ .../ValueObjects/Coupon/CouponPicture.php | 28 ---- .../PrintEligibilityChecker.php | 44 +++++ .../UseCases/Brand/Create/CreateBrandTest.php | 32 +--- .../Create/CreateCampaignRequestTest.php | 11 +- .../Find/FindCampaignRequestTest.php | 5 +- .../Coupon/Create/CreateCouponTest.php | 22 +-- .../UseCases/Coupon/Find/FindCouponTest.php | 6 +- .../Create/CreatePrintableCouponTest.php | 152 ++++++++++++++---- .../List/ListPrintableCouponTest.php | 9 +- .../ValueObjects/Coupon/CouponPictureTest.php | 41 ----- .../Models/ValueObjects/MoneyAmountTest.php | 8 - .../RequestedCouponQuantityTest.php | 17 +- .../RequestedCoupon/RequestedCouponTest.php | 88 ---------- .../Stock/StockAdjustmentTest.php | 24 +-- tests/Unit/Shared/Enums/CountryTest.php | 31 ---- 36 files changed, 384 insertions(+), 362 deletions(-) rename src/Application/UseCases/Brand/Create/{Output.php => Outputs/BrandCreated.php} (81%) create mode 100644 src/Application/UseCases/Brand/Create/Outputs/BrandCreationFailed.php create mode 100644 src/Application/UseCases/Brand/Create/Outputs/CreateBrandError.php rename src/Application/UseCases/CampaignRequest/Create/{Output.php => Outputs/CampaignRequestCreated.php} (86%) create mode 100644 src/Application/UseCases/CampaignRequest/Outputs/BrandNotFound.php create mode 100644 src/Application/UseCases/Coupon/Create/Outputs/CouponCodeAlreadyExists.php rename src/Application/UseCases/Coupon/Create/{Output.php => Outputs/CouponCreated.php} (93%) create mode 100644 src/Application/UseCases/Coupon/Outputs/BrandNotFound.php create mode 100644 src/Application/UseCases/PrintableCoupon/Create/Outputs/CampaignNotFound.php create mode 100644 src/Application/UseCases/PrintableCoupon/Create/Outputs/CampaignNotPublished.php create mode 100644 src/Application/UseCases/PrintableCoupon/Create/Outputs/CouponNotAssociated.php rename src/Application/UseCases/PrintableCoupon/Create/{Output.php => Outputs/PrintableCouponCreated.php} (80%) rename src/Application/UseCases/PrintableCoupon/List/{Output.php => Outputs/PrintableCouponListed.php} (59%) create mode 100644 src/Application/UseCases/PrintableCoupon/Outputs/CouponNotFound.php create mode 100644 src/Domain/Services/PrintableCoupon/PrintEligibilityChecker.php delete mode 100644 tests/Unit/Shared/Enums/CountryTest.php diff --git a/src/Application/UseCases/Brand/Create/CreateBrand.php b/src/Application/UseCases/Brand/Create/CreateBrand.php index c653255..e2f9017 100644 --- a/src/Application/UseCases/Brand/Create/CreateBrand.php +++ b/src/Application/UseCases/Brand/Create/CreateBrand.php @@ -4,6 +4,9 @@ declare(strict_types=1); namespace Application\UseCases\Brand\Create; +use Application\UseCases\Brand\Create\Outputs\BrandCreated; +use Application\UseCases\Brand\Create\Outputs\BrandCreationFailed; +use Application\UseCases\Brand\Create\Outputs\CreateBrandError; use Domain\Models\Entities\Brand; use Domain\Ports\Repositories\BrandRepository; use Domain\Ports\Services\PictureStorage; @@ -12,7 +15,7 @@ use Shared\DDD\UseCases\UseCase; use Shared\DDD\UseCases\Transactional; use Webmozart\Assert\Assert; -/** @implements UseCase<\Application\UseCases\Brand\Create\Input, \Application\UseCases\Brand\Create\Output> */ +/** @implements UseCase<\Application\UseCases\Brand\Create\Input, \Application\UseCases\Brand\Create\Outputs\BrandCreated|\Application\UseCases\Brand\Create\Outputs\BrandCreationFailed> */ final readonly class CreateBrand implements UseCase, Transactional { public function __construct( @@ -22,12 +25,12 @@ final readonly class CreateBrand implements UseCase, Transactional } #[\Override] - public function execute(BaseInput $input): Output + public function execute(BaseInput $input): BrandCreated | BrandCreationFailed { Assert::isInstanceOf($input, Input::class); if ($this->repository->existsByCode($input->code)) { - throw new \DomainException(sprintf('Brand code "%s" already exists.', $input->code->value)); + return new BrandCreationFailed(CreateBrandError::BrandCodeAlreadyExists); } $logoPath = $this->pictureStorage->store($input->logo); @@ -42,7 +45,7 @@ final readonly class CreateBrand implements UseCase, Transactional $this->repository->save($brand); - return new Output( + return new BrandCreated( name: $brand->name, code: $brand->code, logo: $brand->logo, diff --git a/src/Application/UseCases/Brand/Create/Output.php b/src/Application/UseCases/Brand/Create/Outputs/BrandCreated.php similarity index 81% rename from src/Application/UseCases/Brand/Create/Output.php rename to src/Application/UseCases/Brand/Create/Outputs/BrandCreated.php index e931182..ed35630 100644 --- a/src/Application/UseCases/Brand/Create/Output.php +++ b/src/Application/UseCases/Brand/Create/Outputs/BrandCreated.php @@ -2,7 +2,7 @@ declare(strict_types=1); -namespace Application\UseCases\Brand\Create; +namespace Application\UseCases\Brand\Create\Outputs; use Domain\Models\ValueObjects\Brand\BrandCode; use Domain\Models\ValueObjects\Brand\BrandName; @@ -11,7 +11,7 @@ use Shared\ValueObjects\Email; use Domain\Models\ValueObjects\PicturePath; use Shared\ValueObjects\Rcs; -final readonly class Output implements UseCaseOutput +final readonly class BrandCreated implements UseCaseOutput { public function __construct( public BrandName $name, diff --git a/src/Application/UseCases/Brand/Create/Outputs/BrandCreationFailed.php b/src/Application/UseCases/Brand/Create/Outputs/BrandCreationFailed.php new file mode 100644 index 0000000..6c58c7e --- /dev/null +++ b/src/Application/UseCases/Brand/Create/Outputs/BrandCreationFailed.php @@ -0,0 +1,15 @@ + */ +/** @implements UseCase<\Application\UseCases\CampaignRequest\Create\Input, \Shared\DDD\UseCases\Output> */ final readonly class CreateCampaignRequest implements UseCase, Transactional { public function __construct( @@ -27,7 +30,7 @@ final readonly class CreateCampaignRequest implements UseCase, Transactional Assert::isInstanceOf($input, Input::class); if (! $this->brandRepository->existsByCode($input->brandCode)) { - throw new \DomainException(sprintf('Brand with code "%s" was not found.', $input->brandCode->value)); + return new BrandNotFound(); } $campaignRequest = CampaignRequest::create( @@ -40,7 +43,7 @@ final readonly class CreateCampaignRequest implements UseCase, Transactional $this->campaignRequestRepository->save($campaignRequest); - return new Output( + return new CampaignRequestCreated( id: $campaignRequest->id(), brandCode: $campaignRequest->brandCode, name: $campaignRequest->name, diff --git a/src/Application/UseCases/CampaignRequest/Create/Output.php b/src/Application/UseCases/CampaignRequest/Create/Outputs/CampaignRequestCreated.php similarity index 86% rename from src/Application/UseCases/CampaignRequest/Create/Output.php rename to src/Application/UseCases/CampaignRequest/Create/Outputs/CampaignRequestCreated.php index 9571784..ec70e8b 100644 --- a/src/Application/UseCases/CampaignRequest/Create/Output.php +++ b/src/Application/UseCases/CampaignRequest/Create/Outputs/CampaignRequestCreated.php @@ -2,7 +2,7 @@ declare(strict_types=1); -namespace Application\UseCases\CampaignRequest\Create; +namespace Application\UseCases\CampaignRequest\Create\Outputs; use Domain\Models\ValueObjects\Brand\BrandCode; use Domain\Models\ValueObjects\Campaign\CampaignName; @@ -13,7 +13,7 @@ use Domain\Models\ValueObjects\CampaignRequest\CampaignRequestType; use Domain\Models\ValueObjects\RequestedCoupon\RequestedCoupon; use Shared\DDD\UseCases\Output as UseCaseOutput; -final readonly class Output implements UseCaseOutput +final readonly class CampaignRequestCreated implements UseCaseOutput { public function __construct( public CampaignRequestId $id, diff --git a/src/Application/UseCases/CampaignRequest/Find/FindCampaignRequest.php b/src/Application/UseCases/CampaignRequest/Find/FindCampaignRequest.php index 2361ab6..e22e7eb 100644 --- a/src/Application/UseCases/CampaignRequest/Find/FindCampaignRequest.php +++ b/src/Application/UseCases/CampaignRequest/Find/FindCampaignRequest.php @@ -6,7 +6,7 @@ namespace Application\UseCases\CampaignRequest\Find; use Application\UseCases\CampaignRequest\Find\Output\CampaignRequestFound; use Application\UseCases\CampaignRequest\Find\Output\CampaignRequestNotFound; -use Application\UseCases\CampaignRequest\Find\Output\Output; +use Application\UseCases\CampaignRequest\Outputs\BrandNotFound; use Domain\Models\Entities\Brand; use Domain\Models\Entities\CampaignRequest; use Domain\Ports\Repositories\BrandRepository; @@ -25,7 +25,7 @@ final readonly class FindCampaignRequest implements UseCase } #[\Override] - public function execute(BaseInput $input): Output + public function execute(BaseInput $input): CampaignRequestNotFound | CampaignRequestFound | BrandNotFound { Assert::isInstanceOf($input, Input::class); @@ -38,7 +38,7 @@ final readonly class FindCampaignRequest implements UseCase $brand = $this->brandRepository->findByCode($campaignRequest->brandCode); if (! $brand instanceof Brand) { - throw new \DomainException(sprintf('Brand with code "%s" was not found.', $campaignRequest->brandCode->value)); + return new BrandNotFound(); } return new CampaignRequestFound( diff --git a/src/Application/UseCases/CampaignRequest/Outputs/BrandNotFound.php b/src/Application/UseCases/CampaignRequest/Outputs/BrandNotFound.php new file mode 100644 index 0000000..76a0f1f --- /dev/null +++ b/src/Application/UseCases/CampaignRequest/Outputs/BrandNotFound.php @@ -0,0 +1,11 @@ + */ +/** @implements UseCase<\Application\UseCases\Coupon\Create\Input, \Shared\DDD\UseCases\Output> */ final readonly class CreateCoupon implements UseCase, Transactional { public function __construct( @@ -27,11 +31,11 @@ final readonly class CreateCoupon implements UseCase, Transactional Assert::isInstanceOf($input, Input::class); if (! $this->brandRepository->existsByCode($input->brandCode)) { - throw new \DomainException(sprintf('Brand code "%s" was not found.', $input->brandCode->value)); + return new BrandNotFound(); } if ($this->couponRepository->existsByCode($input->code)) { - throw new \DomainException(sprintf('Coupon code "%s" already exists.', $input->code->value)); + return new CouponCodeAlreadyExists(); } $coupon = Coupon::create( @@ -52,7 +56,7 @@ final readonly class CreateCoupon implements UseCase, Transactional $this->couponRepository->save($coupon); - return new Output( + return new CouponCreated( id: $coupon->id, code: $coupon->code, name: $coupon->name, diff --git a/src/Application/UseCases/Coupon/Create/Outputs/CouponCodeAlreadyExists.php b/src/Application/UseCases/Coupon/Create/Outputs/CouponCodeAlreadyExists.php new file mode 100644 index 0000000..4238470 --- /dev/null +++ b/src/Application/UseCases/Coupon/Create/Outputs/CouponCodeAlreadyExists.php @@ -0,0 +1,11 @@ +brandRepository->existsByCode($coupon->brandCode)) { - throw new \DomainException(sprintf('Brand code "%s" was not found.', $coupon->brandCode->value)); + return new BrandNotFound(); } $campaigns = $this->campaignRepository->findByCouponCode($coupon->code); diff --git a/src/Application/UseCases/Coupon/Outputs/BrandNotFound.php b/src/Application/UseCases/Coupon/Outputs/BrandNotFound.php new file mode 100644 index 0000000..a305617 --- /dev/null +++ b/src/Application/UseCases/Coupon/Outputs/BrandNotFound.php @@ -0,0 +1,11 @@ + */ +/** @implements UseCase<\Application\UseCases\PrintableCoupon\Create\Input, \Shared\DDD\UseCases\Output> */ final readonly class CreatePrintableCoupon implements UseCase, Transactional { public function __construct( private PrintableCouponRepository $printableCouponRepository, private CouponRepository $couponRepository, private CampaignRepository $campaignRepository, + private PrintEligibilityChecker $printEligibilityChecker ) { } @@ -35,25 +41,30 @@ final readonly class CreatePrintableCoupon implements UseCase, Transactional $campaign = $this->campaignRepository->findByCode($input->campaignCode); if (! $campaign instanceof Campaign) { - throw new \DomainException(sprintf('Campaign from code "%s" not found.', $input->campaignCode->value)); + return new CampaignNotFound(); } if (! $campaign->publication) { - throw new \DomainException('Campaign must be published.'); + return new CampaignNotPublished(); } $coupon = $this->couponRepository->findByCode($input->couponCode); if (! $coupon instanceof Coupon) { - throw new \DomainException(sprintf('Coupon code "%s" not found.', $input->couponCode->value)); + return new CouponNotFound(); } $campaignCoupon = $this->campaignRepository->findCampaignCoupon($campaign->code, $coupon->code); if (! $campaignCoupon instanceof CampaignCoupon) { - throw new \DomainException('Coupon must be associated to the associated campaign coupon.'); + return new CouponNotAssociated(); } $period = $coupon->getActivePeriod(); - $this->checkPrintRulesFromCampaignCoupon($campaign, $campaignCoupon, $coupon, $input->crmCustomerHashcode); + $this->printEligibilityChecker->checkPrintRulesFromCampaignCoupon( + $campaign, + $campaignCoupon, + $coupon, + $input->crmCustomerHashcode + ); $printableCoupon = PrintableCoupon::create( campaignCode: $campaign->code, @@ -65,7 +76,7 @@ final readonly class CreatePrintableCoupon implements UseCase, Transactional $this->printableCouponRepository->save($printableCoupon); - return new Output( + return new PrintableCouponCreated( campaignCode: $printableCoupon->campaignCode, couponCode: $printableCoupon->couponCode, couponName: $printableCoupon->couponName, @@ -73,28 +84,4 @@ final readonly class CreatePrintableCoupon implements UseCase, Transactional distributableUntil: $printableCoupon->distributableUntil, ); } - - public function checkPrintRulesFromCampaignCoupon( - Campaign $campaign, - CampaignCoupon $campaignCoupon, - Coupon $coupon, - CrmHashcode $crmCustomerHashcode, - ): void { - if ($campaignCoupon->printRules instanceof PrintRules) { - $countPrintedCoupon = $this->printableCouponRepository->countPrintedCouponForCustomer( - $campaign->code, - $coupon->code, - $crmCustomerHashcode, - ); - $campaignCoupon->printRules->hasPrintLimitNotReached($countPrintedCoupon); - - $lastPrintedCoupon = $this->printableCouponRepository->findLastPrintedCouponForCustomer( - $campaign->code, - $coupon->code, - $crmCustomerHashcode, - ); - $diff = $lastPrintedCoupon->printedAt()->diff(new \DateTime()); - $campaignCoupon->printRules->hasReprintPeriodExpired($diff->days); - } - } } diff --git a/src/Application/UseCases/PrintableCoupon/Create/Outputs/CampaignNotFound.php b/src/Application/UseCases/PrintableCoupon/Create/Outputs/CampaignNotFound.php new file mode 100644 index 0000000..38e661b --- /dev/null +++ b/src/Application/UseCases/PrintableCoupon/Create/Outputs/CampaignNotFound.php @@ -0,0 +1,11 @@ + */ +/** @implements UseCase<\Application\UseCases\PrintableCoupon\List\Input, \Shared\DDD\UseCases\Output> */ final readonly class ListPrintableCoupons implements UseCase { public function __construct( @@ -49,7 +52,7 @@ final readonly class ListPrintableCoupons implements UseCase $coupon = $this->couponRepository->findByCode($couponCode); if (!$coupon instanceof Coupon) { - throw new \LogicException(sprintf('Coupon "%s" referenced by a printable coupon does not exist.', $couponCode->value)); + return new CouponNotFound(); } $picturesByCouponCode[$couponCode->value] = $coupon->picture; @@ -66,7 +69,7 @@ final readonly class ListPrintableCoupons implements UseCase $printableCoupons, ); - return new Output( + return new PrintableCouponListed( printableCoupons: new Paginated( pagination: $result->getPagination(), items: $items, diff --git a/src/Application/UseCases/PrintableCoupon/List/Output.php b/src/Application/UseCases/PrintableCoupon/List/Outputs/PrintableCouponListed.php similarity index 59% rename from src/Application/UseCases/PrintableCoupon/List/Output.php rename to src/Application/UseCases/PrintableCoupon/List/Outputs/PrintableCouponListed.php index c6ac9ed..f595b50 100644 --- a/src/Application/UseCases/PrintableCoupon/List/Output.php +++ b/src/Application/UseCases/PrintableCoupon/List/Outputs/PrintableCouponListed.php @@ -2,12 +2,13 @@ declare(strict_types=1); -namespace Application\UseCases\PrintableCoupon\List; +namespace Application\UseCases\PrintableCoupon\List\Outputs; +use Application\UseCases\PrintableCoupon\List\PrintableCouponListItem; use Shared\DDD\UseCases\Output as UseCaseOutput; use Shared\ValueObjects\Pagination\Paginated; -final readonly class Output implements UseCaseOutput +final readonly class PrintableCouponListed implements UseCaseOutput { /** @param Paginated $printableCoupons */ public function __construct( diff --git a/src/Application/UseCases/PrintableCoupon/Outputs/CouponNotFound.php b/src/Application/UseCases/PrintableCoupon/Outputs/CouponNotFound.php new file mode 100644 index 0000000..0160846 --- /dev/null +++ b/src/Application/UseCases/PrintableCoupon/Outputs/CouponNotFound.php @@ -0,0 +1,11 @@ +value) ? getimagesize($decoration->value) : false; - - if ($size === false) { - throw new \DomainException(sprintf('Unable to read the decoration picture "%s".', $decoration)); - } - - [$width, $height] = $size; - - if ($width !== self::DECORATION_WIDTH || $height !== self::DECORATION_HEIGHT) { - throw new \DomainException(sprintf( - 'The decoration picture must be %d x %d px, %d x %d px given.', - self::DECORATION_WIDTH, - self::DECORATION_HEIGHT, - $width, - $height, - )); - } - - return $picture; - } } diff --git a/src/Domain/Services/PrintableCoupon/PrintEligibilityChecker.php b/src/Domain/Services/PrintableCoupon/PrintEligibilityChecker.php new file mode 100644 index 0000000..6d90f27 --- /dev/null +++ b/src/Domain/Services/PrintableCoupon/PrintEligibilityChecker.php @@ -0,0 +1,44 @@ +printRules instanceof PrintRules) { + $countPrintedCoupon = $this->printableCouponRepository->countPrintedCouponForCustomer( + $campaign->code, + $coupon->code, + $crmCustomerHashcode, + ); + $campaignCoupon->printRules->hasPrintLimitNotReached($countPrintedCoupon); + + $lastPrintedCoupon = $this->printableCouponRepository->findLastPrintedCouponForCustomer( + $campaign->code, + $coupon->code, + $crmCustomerHashcode, + ); + $diff = $lastPrintedCoupon->printedAt()->diff(new \DateTime()); + $campaignCoupon->printRules->hasReprintPeriodExpired($diff->days); + } + } +} diff --git a/tests/Unit/Application/UseCases/Brand/Create/CreateBrandTest.php b/tests/Unit/Application/UseCases/Brand/Create/CreateBrandTest.php index d7e81b6..fd3dfd9 100644 --- a/tests/Unit/Application/UseCases/Brand/Create/CreateBrandTest.php +++ b/tests/Unit/Application/UseCases/Brand/Create/CreateBrandTest.php @@ -4,21 +4,22 @@ declare(strict_types=1); namespace Tests\Unit\Application\UseCases\Brand\Create; +use Application\UseCases\Brand\Create\Outputs\BrandCreated; +use Application\UseCases\Brand\Create\Outputs\BrandCreationFailed; +use Application\UseCases\Brand\Create\Outputs\CreateBrandError; use Application\UseCases\Brand\Create\CreateBrand; use Application\UseCases\Brand\Create\Input; -use Application\UseCases\Brand\Create\Output; use Domain\Models\Entities\Brand; use Domain\Models\ValueObjects\Brand\BrandCode; use Domain\Models\ValueObjects\Brand\BrandName; use Domain\Ports\Repositories\BrandRepository; use Domain\Ports\Services\PictureStorage; -use Shared\DDD\UseCases\Input as BaseInput; use Shared\ValueObjects\Email; use Domain\Models\ValueObjects\PicturePath; use Domain\Models\ValueObjects\RawPicturePath; use Shared\ValueObjects\Rcs; -covers(CreateBrand::class, Input::class, Output::class); +covers(CreateBrand::class, Input::class, BrandCreated::class, BrandCreationFailed::class); describe('create brand use case', function (): void { it('creates a brand when the code is unique and valid', function (): void { @@ -47,7 +48,7 @@ describe('create brand use case', function (): void { $result = $useCase->execute($input); // THEN - expect($result)->toBeInstanceOf(Output::class) + expect($result)->toBeInstanceOf(BrandCreated::class) ->and($result->code)->toBeInstanceOf(BrandCode::class); }); }); @@ -73,27 +74,10 @@ describe('create brand use case validation rules', function (): void { $useCase = new CreateBrand($repository, $pictureStorage); // WHEN - $action = fn (): Output => $useCase->execute($input); + $result = $useCase->execute($input); // THEN - expect($action)->toThrow(\DomainException::class); - }); -}); - -describe('create brand use case assertions', function (): void { - it('rejects an input of the wrong type', function (): void { - // GIVEN - $repository = \Mockery::mock(BrandRepository::class); - $pictureStorage = \Mockery::mock(PictureStorage::class); - $useCase = new CreateBrand($repository, $pictureStorage); - $invalidInput = new class () implements BaseInput - { - }; - - // WHEN - $action = fn (): Output => $useCase->execute($invalidInput); - - // THEN - expect($action)->toThrow(\InvalidArgumentException::class); + expect($result)->toBeInstanceOf(BrandCreationFailed::class) + ->and($result->error)->toBeInstanceOf(CreateBrandError::class); }); }); diff --git a/tests/Unit/Application/UseCases/CampaignRequest/Create/CreateCampaignRequestTest.php b/tests/Unit/Application/UseCases/CampaignRequest/Create/CreateCampaignRequestTest.php index 4bb30ed..bc84167 100644 --- a/tests/Unit/Application/UseCases/CampaignRequest/Create/CreateCampaignRequestTest.php +++ b/tests/Unit/Application/UseCases/CampaignRequest/Create/CreateCampaignRequestTest.php @@ -6,7 +6,8 @@ namespace Tests\Unit\Application\UseCases\CampaignRequest\Create; use Application\UseCases\CampaignRequest\Create\CreateCampaignRequest; use Application\UseCases\CampaignRequest\Create\Input; -use Application\UseCases\CampaignRequest\Create\Output; +use Application\UseCases\CampaignRequest\Create\Outputs\CampaignRequestCreated; +use Application\UseCases\CampaignRequest\Outputs\BrandNotFound; use DateTime; use Domain\Models\Entities\CampaignRequest; use Domain\Models\ValueObjects\Brand\BrandCode; @@ -37,7 +38,7 @@ use Shared\Enums\Currency; use Shared\ValueObjects\Email; use Shared\ValueObjects\Money; -covers(CreateCampaignRequest::class, Input::class, Output::class); +covers(CreateCampaignRequest::class, Input::class, CampaignRequestCreated::class); describe('create campaign request use case', function (): void { $makeInput = fn (): Input => new Input( @@ -88,7 +89,7 @@ describe('create campaign request use case', function (): void { $result = $useCase->execute($input); // THEN - expect($result)->toBeInstanceOf(Output::class) + expect($result)->toBeInstanceOf(CampaignRequestCreated::class) ->and($result->status)->toBe(CampaignRequestStatus::CREATED) ->and($result->brandCode)->toBe($input->brandCode); }); @@ -106,9 +107,9 @@ describe('create campaign request use case', function (): void { $useCase = new CreateCampaignRequest($campaignRequestRepository, $brandRepository); // WHEN - $action = fn (): Output => $useCase->execute($input); + $result = $useCase->execute($input); // THEN - expect($action)->toThrow(\DomainException::class); + expect($result)->toBeInstanceOf(BrandNotFound::class); }); }); diff --git a/tests/Unit/Application/UseCases/CampaignRequest/Find/FindCampaignRequestTest.php b/tests/Unit/Application/UseCases/CampaignRequest/Find/FindCampaignRequestTest.php index dd00697..0465890 100644 --- a/tests/Unit/Application/UseCases/CampaignRequest/Find/FindCampaignRequestTest.php +++ b/tests/Unit/Application/UseCases/CampaignRequest/Find/FindCampaignRequestTest.php @@ -9,6 +9,7 @@ use Application\UseCases\CampaignRequest\Find\Input; use Application\UseCases\CampaignRequest\Find\Output\CampaignRequestFound; use Application\UseCases\CampaignRequest\Find\Output\CampaignRequestNotFound; use Application\UseCases\CampaignRequest\Find\Output\Output; +use Application\UseCases\CampaignRequest\Outputs\BrandNotFound; use DateTime; use Domain\Models\Entities\Brand; use Domain\Models\Entities\CampaignRequest; @@ -203,10 +204,10 @@ describe('find campaign request use case', function (): void { $useCase = new FindCampaignRequest($repository, $brandRepository); // WHEN - $action = fn (): Output => $useCase->execute(new Input(id: $id)); + $result = $useCase->execute(new Input(id: $id)); // THEN - expect($action)->toThrow(\DomainException::class); + expect($result)->toBeInstanceOf(BrandNotFound::class); }); }); diff --git a/tests/Unit/Application/UseCases/Coupon/Create/CreateCouponTest.php b/tests/Unit/Application/UseCases/Coupon/Create/CreateCouponTest.php index 5e71918..7bc475b 100644 --- a/tests/Unit/Application/UseCases/Coupon/Create/CreateCouponTest.php +++ b/tests/Unit/Application/UseCases/Coupon/Create/CreateCouponTest.php @@ -6,7 +6,9 @@ namespace Tests\Unit\Application\UseCases\Coupon\Create; use Application\UseCases\Coupon\Create\CreateCoupon; use Application\UseCases\Coupon\Create\Input; -use Application\UseCases\Coupon\Create\Output; +use Application\UseCases\Coupon\Create\Outputs\CouponCreated; +use Application\UseCases\Coupon\Outputs\BrandNotFound; +use Application\UseCases\Coupon\Create\Outputs\CouponCodeAlreadyExists; use DateTime; use Domain\Models\Entities\Coupon; use Domain\Models\ValueObjects\Actor\ActorId; @@ -36,7 +38,7 @@ use Shared\Enums\Country; use Shared\Enums\Currency; use Shared\ValueObjects\Money; -covers(CreateCoupon::class, Input::class, Output::class); +covers(CreateCoupon::class, Input::class, CouponCreated::class, CouponCodeAlreadyExists::class); describe('create coupon use case', function (): void { $makeInput = fn (array $overrides = []): Input => new Input(...array_merge([ @@ -86,7 +88,7 @@ describe('create coupon use case', function (): void { $result = $useCase->execute($input); // THEN - expect($result)->toBeInstanceOf(Output::class) + expect($result)->toBeInstanceOf(CouponCreated::class) ->and($result->id)->toBeInstanceOf(CouponId::class) ->and($result->code)->toEqual($input->code) ->and($result->name)->toEqual($input->name) @@ -117,10 +119,10 @@ describe('create coupon use case', function (): void { $useCase = new CreateCoupon($couponRepository, $brandRepository); // WHEN - $action = fn (): Output => $useCase->execute($input); + $result = $useCase->execute($input); // THEN - expect($action)->toThrow(\DomainException::class, 'Brand code "TST89" was not found.'); + expect($result)->toBeInstanceOf(BrandNotFound::class); }); it('throws when the coupon code already exists', function () use ($makeInput): void { @@ -137,10 +139,10 @@ describe('create coupon use case', function (): void { $useCase = new CreateCoupon($couponRepository, $brandRepository); // WHEN - $action = fn (): Output => $useCase->execute($input); + $result = $useCase->execute($input); // THEN - expect($action)->toThrow(\DomainException::class, 'Coupon code "COU01" already exists.'); + expect($result)->toBeInstanceOf(CouponCodeAlreadyExists::class); }); it('creates a coupon with an availability calendar', function () use ($makeInput): void { @@ -248,7 +250,7 @@ describe('create coupon use case', function (): void { $useCase = new CreateCoupon($couponRepository, $brandRepository); // WHEN - $action = fn (): Output => $useCase->execute($input); + $action = fn () => $useCase->execute($input); // THEN expect($action)->toThrow(\DomainException::class, 'A coupon requires legal information for BENELUX.'); @@ -277,7 +279,7 @@ describe('create coupon use case', function (): void { $useCase = new CreateCoupon($couponRepository, $brandRepository); // WHEN - $action = fn (): Output => $useCase->execute($input); + $action = fn () => $useCase->execute($input); // THEN expect($action)->toThrow(\DomainException::class, 'A coupon requires validity information for BENELUX.'); @@ -335,7 +337,7 @@ describe('create coupon use case assertions', function (): void { }; // WHEN - $action = fn (): Output => $useCase->execute($invalidInput); + $action = fn () => $useCase->execute($invalidInput); // THEN expect($action)->toThrow(\InvalidArgumentException::class); diff --git a/tests/Unit/Application/UseCases/Coupon/Find/FindCouponTest.php b/tests/Unit/Application/UseCases/Coupon/Find/FindCouponTest.php index 4ef0ce1..b907f42 100644 --- a/tests/Unit/Application/UseCases/Coupon/Find/FindCouponTest.php +++ b/tests/Unit/Application/UseCases/Coupon/Find/FindCouponTest.php @@ -8,7 +8,7 @@ use Application\UseCases\Coupon\Find\FindCoupon; use Application\UseCases\Coupon\Find\Input; use Application\UseCases\Coupon\Find\Output\CouponFound; use Application\UseCases\Coupon\Find\Output\CouponNotFound; -use Application\UseCases\Coupon\Find\Output\Output; +use Application\UseCases\Coupon\Outputs\BrandNotFound; use DateTime; use Domain\Models\Entities\Brand; use Domain\Models\Entities\Campaign; @@ -181,8 +181,8 @@ describe('find coupon use case', function (): void { $useCase = new FindCoupon($couponRepository, $brandRepository, $campaignRepository); // WHEN / THEN - expect(fn (): Output => $useCase->execute(new Input(code: $coupon->code))) - ->toThrow(\DomainException::class); + expect($useCase->execute(new Input(code: $coupon->code))) + ->toBeInstanceOf(BrandNotFound::class); }); it('finds a coupon not attached to any campaign', function () use ($coupon): void { diff --git a/tests/Unit/Application/UseCases/PrintableCoupon/Create/CreatePrintableCouponTest.php b/tests/Unit/Application/UseCases/PrintableCoupon/Create/CreatePrintableCouponTest.php index 3cf50bb..ab1dd2d 100644 --- a/tests/Unit/Application/UseCases/PrintableCoupon/Create/CreatePrintableCouponTest.php +++ b/tests/Unit/Application/UseCases/PrintableCoupon/Create/CreatePrintableCouponTest.php @@ -5,8 +5,12 @@ declare(strict_types=1); namespace Tests\Unit\Application\UseCases\PrintableCoupon\Create; use Application\UseCases\PrintableCoupon\Create\Input; -use Application\UseCases\PrintableCoupon\Create\Output; use Application\UseCases\PrintableCoupon\Create\CreatePrintableCoupon; +use Application\UseCases\PrintableCoupon\Create\Outputs\CampaignNotFound; +use Application\UseCases\PrintableCoupon\Create\Outputs\CampaignNotPublished; +use Application\UseCases\PrintableCoupon\Create\Outputs\CouponNotAssociated; +use Application\UseCases\PrintableCoupon\Create\Outputs\PrintableCouponCreated; +use Application\UseCases\PrintableCoupon\Outputs\CouponNotFound; use DateTime; use Domain\Models\Entities\Campaign; use Domain\Models\Entities\Coupon; @@ -44,13 +48,14 @@ use Domain\Models\ValueObjects\ProcessingCodeArray; use Domain\Ports\Repositories\CampaignRepository; use Domain\Ports\Repositories\CouponRepository; use Domain\Ports\Repositories\PrintableCouponRepository; +use Domain\Services\PrintableCoupon\PrintEligibilityChecker; use Ramsey\Uuid\Uuid; use Shared\Enums\Country; use Shared\Enums\Currency; use Shared\Helpers\DatesHelper; use Shared\ValueObjects\Money; -covers(CreatePrintableCoupon::class, Input::class, Output::class); +covers(CreatePrintableCoupon::class, Input::class, PrintableCouponCreated::class); describe('create coupon use case', function (): void { $crmCustomerHashcode = new CrmHashcode(Uuid::uuid4()); @@ -93,7 +98,7 @@ describe('create coupon use case', function (): void { brandCode: $brandCode, createdBy: ActorId::generate(), products: new CouponProductArray([ - new IncoCode(35784) , + new IncoCode(35784), new IncoCode(15522), ]), movements: new CouponMovementArray([ @@ -152,13 +157,22 @@ describe('create coupon use case', function (): void { $printableCouponRepository = \Mockery::mock(PrintableCouponRepository::class); $printableCouponRepository->shouldReceive('save')->once()->with(\Mockery::type(PrintableCoupon::class)); - $useCase = new CreatePrintableCoupon($printableCouponRepository, $couponRepository, $campaignRepository); + $printEligibilityChecker = new PrintEligibilityChecker( + $printableCouponRepository, + ); + + $useCase = new CreatePrintableCoupon( + $printableCouponRepository, + $couponRepository, + $campaignRepository, + $printEligibilityChecker, + ); // WHEN $result = $useCase->execute($input); // THEN - expect($result)->toBeInstanceOf(Output::class) + expect($result)->toBeInstanceOf(PrintableCouponCreated::class) ->and($result->campaignCode)->toEqual($campaign->code) ->and($result->couponCode)->toEqual($coupon->code) ->and($result->crmCustomerHashcode)->toEqual($crmCustomerHashcode) @@ -177,13 +191,22 @@ describe('create coupon use case', function (): void { $printableCouponRepository = \Mockery::mock(PrintableCouponRepository::class); - $useCase = new CreatePrintableCoupon($printableCouponRepository, $couponRepository, $campaignRepository); + $printEligibilityChecker = new PrintEligibilityChecker( + $printableCouponRepository, + ); + + $useCase = new CreatePrintableCoupon( + $printableCouponRepository, + $couponRepository, + $campaignRepository, + $printEligibilityChecker, + ); // WHEN - $action = fn (): Output => $useCase->execute($input); + $result = $useCase->execute($input); // THEN - expect($action)->toThrow(\DomainException::class, sprintf('Campaign from code "%s" not found.', $input->campaignCode->value)); + expect($result)->toBeInstanceOf(CampaignNotFound::class); }); it('rejects a printable coupon when campaign is not published', function () use ($makeInput, $makeCampaign): void { @@ -198,13 +221,23 @@ describe('create coupon use case', function (): void { $printableCouponRepository = \Mockery::mock(PrintableCouponRepository::class); - $useCase = new CreatePrintableCoupon($printableCouponRepository, $couponRepository, $campaignRepository); + $printEligibilityChecker = new PrintEligibilityChecker( + $printableCouponRepository, + ); + + $useCase = new CreatePrintableCoupon( + $printableCouponRepository, + $couponRepository, + $campaignRepository, + $printEligibilityChecker, + ); // WHEN - $action = fn (): Output => $useCase->execute($input); + // WHEN + $result = $useCase->execute($input); // THEN - expect($action)->toThrow(\DomainException::class, 'Campaign must be published.'); + expect($result)->toBeInstanceOf(CampaignNotPublished::class); }); it('rejects a printable coupon when coupon is not found', function () use ($makeInput, $makeCampaign, $makeCoupon): void { @@ -221,13 +254,23 @@ describe('create coupon use case', function (): void { $printableCouponRepository = \Mockery::mock(PrintableCouponRepository::class); - $useCase = new CreatePrintableCoupon($printableCouponRepository, $couponRepository, $campaignRepository); + $printEligibilityChecker = new PrintEligibilityChecker( + $printableCouponRepository, + ); + + $useCase = new CreatePrintableCoupon( + $printableCouponRepository, + $couponRepository, + $campaignRepository, + $printEligibilityChecker, + ); // WHEN - $action = fn (): Output => $useCase->execute($input); + // WHEN + $result = $useCase->execute($input); // THEN - expect($action)->toThrow(\DomainException::class, sprintf('Coupon code "%s" not found.', $input->couponCode->value)); + expect($result)->toBeInstanceOf(CouponNotFound::class); }); it('rejects a printable coupon when campaign coupon is not found', function () use ($makeInput, $makeCampaign, $makeCoupon): void { @@ -246,13 +289,23 @@ describe('create coupon use case', function (): void { $printableCouponRepository = \Mockery::mock(PrintableCouponRepository::class); - $useCase = new CreatePrintableCoupon($printableCouponRepository, $couponRepository, $campaignRepository); + $printEligibilityChecker = new PrintEligibilityChecker( + $printableCouponRepository, + ); + + $useCase = new CreatePrintableCoupon( + $printableCouponRepository, + $couponRepository, + $campaignRepository, + $printEligibilityChecker, + ); // WHEN - $action = fn (): Output => $useCase->execute($input); + // WHEN + $result = $useCase->execute($input); // THEN - expect($action)->toThrow(\DomainException::class, 'Coupon must be associated to the associated campaign coupon.'); + expect($result)->toBeInstanceOf(CouponNotAssociated::class); }); it('rejects a printable coupon when outside of diffusion start', function () use ($makeInput, $makeCampaign, $makeCoupon, $campaignCoupon): void { @@ -271,10 +324,19 @@ describe('create coupon use case', function (): void { $printableCouponRepository = \Mockery::mock(PrintableCouponRepository::class); - $useCase = new CreatePrintableCoupon($printableCouponRepository, $couponRepository, $campaignRepository); + $printEligibilityChecker = new PrintEligibilityChecker( + $printableCouponRepository, + ); + + $useCase = new CreatePrintableCoupon( + $printableCouponRepository, + $couponRepository, + $campaignRepository, + $printEligibilityChecker, + ); // WHEN - $action = fn (): Output => $useCase->execute($input); + $action = fn () => $useCase->execute($input); // THEN expect($action)->toThrow(\DomainException::class, 'The printing period has not yet begun.'); @@ -296,10 +358,19 @@ describe('create coupon use case', function (): void { $printableCouponRepository = \Mockery::mock(PrintableCouponRepository::class); - $useCase = new CreatePrintableCoupon($printableCouponRepository, $couponRepository, $campaignRepository); + $printEligibilityChecker = new PrintEligibilityChecker( + $printableCouponRepository, + ); + + $useCase = new CreatePrintableCoupon( + $printableCouponRepository, + $couponRepository, + $campaignRepository, + $printEligibilityChecker, + ); // WHEN - $action = fn (): Output => $useCase->execute($input); + $action = fn () => $useCase->execute($input); // THEN expect($action)->toThrow(\DomainException::class, 'The printing period has expired.'); @@ -337,13 +408,22 @@ describe('create coupon use case', function (): void { $printableCouponRepository = \Mockery::mock(PrintableCouponRepository::class); $printableCouponRepository->shouldReceive('save')->once()->with(\Mockery::type(PrintableCoupon::class)); - $useCase = new CreatePrintableCoupon($printableCouponRepository, $couponRepository, $campaignRepository); + $printEligibilityChecker = new PrintEligibilityChecker( + $printableCouponRepository, + ); + + $useCase = new CreatePrintableCoupon( + $printableCouponRepository, + $couponRepository, + $campaignRepository, + $printEligibilityChecker, + ); // WHEN $result = $useCase->execute($input); // THEN - expect($result)->toBeInstanceOf(Output::class) + expect($result)->toBeInstanceOf(PrintableCouponCreated::class) ->and($result->campaignCode)->toEqual($campaign->code) ->and($result->crmCustomerHashcode)->toEqual($crmCustomerHashcode) ->and($result->distributableUntil)->toEqual($calendarEnd); @@ -376,10 +456,19 @@ describe('create coupon use case', function (): void { $crmCustomerHashcode, )->andReturn(5); - $useCase = new CreatePrintableCoupon($printableCouponRepository, $couponRepository, $campaignRepository); + $printEligibilityChecker = new PrintEligibilityChecker( + $printableCouponRepository, + ); + + $useCase = new CreatePrintableCoupon( + $printableCouponRepository, + $couponRepository, + $campaignRepository, + $printEligibilityChecker, + ); // WHEN - $action = fn (): Output => $useCase->execute($input); + $action = fn () => $useCase->execute($input); // THEN expect($action)->toThrow(\DomainException::class, 'Maximum number of prints reached.'); @@ -418,10 +507,19 @@ describe('create coupon use case', function (): void { $crmCustomerHashcode, )->andReturn($printedCoupon); - $useCase = new CreatePrintableCoupon($printableCouponRepository, $couponRepository, $campaignRepository); + $printEligibilityChecker = new PrintEligibilityChecker( + $printableCouponRepository, + ); + + $useCase = new CreatePrintableCoupon( + $printableCouponRepository, + $couponRepository, + $campaignRepository, + $printEligibilityChecker, + ); // WHEN - $action = fn (): Output => $useCase->execute($input); + $action = fn () => $useCase->execute($input); // THEN expect($action)->toThrow(\DomainException::class, 'Reprint period has not expired.'); diff --git a/tests/Unit/Application/UseCases/PrintableCoupon/List/ListPrintableCouponTest.php b/tests/Unit/Application/UseCases/PrintableCoupon/List/ListPrintableCouponTest.php index 59e6113..a3a2504 100644 --- a/tests/Unit/Application/UseCases/PrintableCoupon/List/ListPrintableCouponTest.php +++ b/tests/Unit/Application/UseCases/PrintableCoupon/List/ListPrintableCouponTest.php @@ -6,8 +6,9 @@ namespace Tests\Unit\Application\UseCases\PrintableCoupon\List; use Application\UseCases\PrintableCoupon\List\Input; use Application\UseCases\PrintableCoupon\List\ListPrintableCoupons; -use Application\UseCases\PrintableCoupon\List\Output; +use Application\UseCases\PrintableCoupon\List\Outputs\PrintableCouponListed; use Application\UseCases\PrintableCoupon\List\PrintableCouponListItem; +use Application\UseCases\PrintableCoupon\Outputs\CouponNotFound; use DateTime; use Domain\Models\Entities\Coupon; use Domain\Models\Entities\PrintableCoupon; @@ -44,7 +45,7 @@ use Shared\ValueObjects\Money; use Shared\ValueObjects\Pagination\Paginated; use Shared\ValueObjects\Pagination\Pagination; -covers(ListPrintableCoupons::class, Input::class, Output::class, PrintableCouponListItem::class); +covers(ListPrintableCoupons::class, Input::class, PrintableCouponListed::class, PrintableCouponListItem::class); describe('list printable coupons use case', function (): void { $createPicture = fn (string $name): CouponPicture => new CouponPicture( @@ -269,9 +270,9 @@ describe('list printable coupons use case', function (): void { $useCase = new ListPrintableCoupons($repository, $couponRepository); // WHEN - $action = fn (): Output => $useCase->execute($input); + $result = $useCase->execute($input); // THEN - expect($action)->toThrow(\LogicException::class); + expect($result)->toBeInstanceOf(CouponNotFound::class); }); }); diff --git a/tests/Unit/Domain/Models/ValueObjects/Coupon/CouponPictureTest.php b/tests/Unit/Domain/Models/ValueObjects/Coupon/CouponPictureTest.php index c8e2903..8b6b752 100644 --- a/tests/Unit/Domain/Models/ValueObjects/Coupon/CouponPictureTest.php +++ b/tests/Unit/Domain/Models/ValueObjects/Coupon/CouponPictureTest.php @@ -41,45 +41,4 @@ describe('coupon picture', function (): void { 'thumbnail' => ['files/decoration.jpg', 'files/thumbnail.webp', 'files/mobile_thumbnail.jpg', 'files/thumbnail.webp'], 'mobile thumbnail' => ['files/decoration.jpg', 'files/thumbnail.jpg', 'files/mobile_thumbnail.png', 'files/mobile_thumbnail.png'], ]); - - it('creates a picture when the decoration is 280 x 260', function (): void { - // GIVEN - $decoration = new PicturePath('tests/Fixtures/Coupon/decoration.jpg'); - $thumbnail = new PicturePath('files/thumbnail.jpg'); - $mobileThumbnail = new PicturePath('files/mobile_thumbnail.jpg'); - - // WHEN - $picture = CouponPicture::create($decoration, $thumbnail, $mobileThumbnail); - - // THEN - expect($picture->decoration)->toBe($decoration) - ->and($picture->thumbnail)->toBe($thumbnail) - ->and($picture->mobileThumbnail)->toBe($mobileThumbnail); - }); - - it('refuses a decoration with the wrong size', function (): void { - // GIVEN - $decoration = new PicturePath('tests/Fixtures/Coupon/invalid_decoration.jpg'); - $thumbnail = new PicturePath('files/thumbnail.jpg'); - $mobileThumbnail = new PicturePath('files/mobile_thumbnail.jpg'); - - // WHEN - $create = fn (): CouponPicture => CouponPicture::create($decoration, $thumbnail, $mobileThumbnail); - - // THEN - expect($create)->toThrow(\DomainException::class, 'The decoration picture must be 280 x 260 px'); - }); - - it('refuses a decoration file that does not exist', function (): void { - // GIVEN - $decoration = new PicturePath('files/missing.jpg'); - $thumbnail = new PicturePath('files/thumbnail.jpg'); - $mobileThumbnail = new PicturePath('files/mobile_thumbnail.jpg'); - - // WHEN - $create = fn (): CouponPicture => CouponPicture::create($decoration, $thumbnail, $mobileThumbnail); - - // THEN - expect($create)->toThrow(\DomainException::class, 'Unable to read the decoration picture "files/missing.jpg".'); - }); }); diff --git a/tests/Unit/Domain/Models/ValueObjects/MoneyAmountTest.php b/tests/Unit/Domain/Models/ValueObjects/MoneyAmountTest.php index ee12511..069b75b 100644 --- a/tests/Unit/Domain/Models/ValueObjects/MoneyAmountTest.php +++ b/tests/Unit/Domain/Models/ValueObjects/MoneyAmountTest.php @@ -54,14 +54,6 @@ describe('money amount', function (): void { expect($amount->value)->toBe($minimumMoney); }); - it('accepts the maximum amount of 3.00€', function () use ($money): void { - // GIVEN / WHEN - $amount = new MoneyAmount($money); - - // THEN - expect($amount->value)->toBe($money); - }); - it('throws when the amount is zero', function () use ($zeroMoney): void { // GIVEN / WHEN / THEN expect(fn (): MoneyAmount => new MoneyAmount($zeroMoney)) diff --git a/tests/Unit/Domain/Models/ValueObjects/RequestedCoupon/RequestedCouponQuantityTest.php b/tests/Unit/Domain/Models/ValueObjects/RequestedCoupon/RequestedCouponQuantityTest.php index e6bfc09..f158d7a 100644 --- a/tests/Unit/Domain/Models/ValueObjects/RequestedCoupon/RequestedCouponQuantityTest.php +++ b/tests/Unit/Domain/Models/ValueObjects/RequestedCoupon/RequestedCouponQuantityTest.php @@ -22,19 +22,14 @@ describe('quantity', function (): void { ->and($quantity->value)->toBe($value); }); - it('rejects a quantity of zero', function () use ($zeroValue): void { + it('rejects a quantity of zero or negative', function (int $value): void { // GIVEN / WHEN - $action = fn (): RequestedCouponQuantity => new RequestedCouponQuantity($zeroValue); + $action = fn (): RequestedCouponQuantity => new RequestedCouponQuantity($value); // THEN expect($action)->toThrow(\DomainException::class, 'Quantity should be more than 0.'); - }); - - it('rejects a negative quantity', function () use ($negativeValue): void { - // GIVEN / WHEN - $action = fn (): RequestedCouponQuantity => new RequestedCouponQuantity($negativeValue); - - // THEN - expect($action)->toThrow(\DomainException::class, 'Quantity should be more than 0.'); - }); + })->with([ + $zeroValue, + $negativeValue, + ]); }); diff --git a/tests/Unit/Domain/Models/ValueObjects/RequestedCoupon/RequestedCouponTest.php b/tests/Unit/Domain/Models/ValueObjects/RequestedCoupon/RequestedCouponTest.php index 392fa6a..66e0aa4 100644 --- a/tests/Unit/Domain/Models/ValueObjects/RequestedCoupon/RequestedCouponTest.php +++ b/tests/Unit/Domain/Models/ValueObjects/RequestedCoupon/RequestedCouponTest.php @@ -175,40 +175,6 @@ describe('requested coupon', function (): void { ->and($coupon->couponProducts)->toBe($couponProducts); }); - it('accepts a france only coupon', function () use ( - $couponName, - $quantity, - $diffusion, - $moneyAmount, - $couponPicture, - $franceProcessingCode, - $franceValidityInformation, - $franceLegalInformation, - $couponProducts, - ): void { - // GIVEN / WHEN - $coupon = new RequestedCoupon( - couponName: $couponName, - quantity: $quantity, - diffusion: $diffusion, - moneyAmount: $moneyAmount, - couponPicture: $couponPicture, - couponProcessingCodes: new ProcessingCodeArray([ - $franceProcessingCode, - ]), - couponValidityInformations: new CouponValidityInformationArray([ - $franceValidityInformation, - ]), - couponLegalInformations: new CouponLegalInformationArray([ - $franceLegalInformation, - ]), - couponProducts: $couponProducts, - ); - - // THEN - expect($coupon)->toBeInstanceOf(RequestedCoupon::class); - }); - it('throws when there is no processing code for france', function () use ( $couponName, $quantity, @@ -235,58 +201,4 @@ describe('requested coupon', function (): void { couponProducts: $couponProducts, ))->toThrow(\DomainException::class, 'ProcessingCodes requires a ProcessingCode for France.'); }); - - it('throws when a benelux processing code has no benelux validity information', function () use ( - $couponName, - $quantity, - $diffusion, - $moneyAmount, - $couponPicture, - $couponProcessingCodes, - $franceValidityInformation, - $couponLegalInformations, - $couponProducts, - ): void { - // GIVEN / WHEN / THEN - expect(fn (): RequestedCoupon => new RequestedCoupon( - couponName: $couponName, - quantity: $quantity, - diffusion: $diffusion, - moneyAmount: $moneyAmount, - couponPicture: $couponPicture, - couponProcessingCodes: $couponProcessingCodes, - couponValidityInformations: new CouponValidityInformationArray([ - $franceValidityInformation, - ]), - couponLegalInformations: $couponLegalInformations, - couponProducts: $couponProducts, - ))->toThrow(\DomainException::class, 'A coupon requires validity information for BENELUX.'); - }); - - it('throws when a benelux processing code has no benelux legal information', function () use ( - $couponName, - $quantity, - $diffusion, - $moneyAmount, - $couponPicture, - $couponProcessingCodes, - $couponValidityInformations, - $franceLegalInformation, - $couponProducts, - ): void { - // GIVEN / WHEN / THEN - expect(fn (): RequestedCoupon => new RequestedCoupon( - couponName: $couponName, - quantity: $quantity, - diffusion: $diffusion, - moneyAmount: $moneyAmount, - couponPicture: $couponPicture, - couponProcessingCodes: $couponProcessingCodes, - couponValidityInformations: $couponValidityInformations, - couponLegalInformations: new CouponLegalInformationArray([ - $franceLegalInformation, - ]), - couponProducts: $couponProducts, - ))->toThrow(\DomainException::class, 'A coupon requires legal information for BENELUX.'); - }); }); diff --git a/tests/Unit/Domain/Models/ValueObjects/Stock/StockAdjustmentTest.php b/tests/Unit/Domain/Models/ValueObjects/Stock/StockAdjustmentTest.php index c897668..2f8ee28 100644 --- a/tests/Unit/Domain/Models/ValueObjects/Stock/StockAdjustmentTest.php +++ b/tests/Unit/Domain/Models/ValueObjects/Stock/StockAdjustmentTest.php @@ -51,33 +51,21 @@ describe('stock adjustment', function (): void { expect($adjustment->createdAt)->toBe($createdAt); }); - it('rejects a quantity of zero', function () use ($zeroQuantity, $reason): void { + it('rejects a quantity of zero or negative', function (int $value) use ($reason): void { // GIVEN $actorId = ActorId::generate(); // WHEN $action = fn (): StockAdjustment => new StockAdjustment( - $zeroQuantity, + $value, $reason, $actorId, ); // THEN expect($action)->toThrow(\DomainException::class, 'Stock Amount should be more than 0.'); - }); - - it('rejects a negative quantity', function () use ($negativeQuantity, $reason): void { - // GIVEN - $actorId = ActorId::generate(); - - // WHEN - $action = fn (): StockAdjustment => new StockAdjustment( - $negativeQuantity, - $reason, - $actorId, - ); - - // THEN - expect($action)->toThrow(\DomainException::class, 'Stock Amount should be more than 0.'); - }); + })->with([ + $zeroQuantity, + $negativeQuantity, + ]); }); diff --git a/tests/Unit/Shared/Enums/CountryTest.php b/tests/Unit/Shared/Enums/CountryTest.php deleted file mode 100644 index e548d13..0000000 --- a/tests/Unit/Shared/Enums/CountryTest.php +++ /dev/null @@ -1,31 +0,0 @@ -value)->toBe('france') - ->and(Country::BENELUX->value)->toBe('benelux'); - }); - - it('exposes its case name', function (): void { - // THEN - expect(Country::FRANCE->name)->toBe('FRANCE'); - }); - - it('is a domain exception', function (): void { - // GIVEN / WHEN - $exception = UnknownCountryIsoCodeException::fromIsoCode('XX'); - - // THEN - expect($exception)->toBeInstanceOf(\DomainException::class); - }); -});