forge-joniko/ldc-tid-logistique
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 6

Fix incorrect cursor rendering at (0,0) position

Browse source
This commit is contained in:
Gaurav Ujjwal 2022-03-26 17:47:08 +05:30
parent 36d8b66cae
commit ce2736ed20
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/src/main/cpp/native-vnc.cpp
View file

@ -455,7 +455,7 @@ Java_com_gaurav_avnc_vnc_VncClient_nativeUploadCursor(JNIEnv *env, jobject thiz,
//Cursor can overflow outside the framebuffer if moved near the edges, //Cursor can overflow outside the framebuffer if moved near the edges,
//but glTexSubImage2D() doesn't allow values outside target texture, //but glTexSubImage2D() doesn't allow values outside target texture,
//so we need to only update the intersection of framebuffer & cursor. //so we need to only update the intersection of framebuffer & cursor.
int32_t left = 0, top = 0, right = 0, bottom = 0; int32_t left = -1, top = -1, right = -1, bottom = -1;
auto fb = (uint32_t *) client->frameBuffer; auto fb = (uint32_t *) client->frameBuffer;
auto buffer = (uint32_t *) cursor->buffer; auto buffer = (uint32_t *) cursor->buffer;
@ -479,7 +479,7 @@ Java_com_gaurav_avnc_vnc_VncClient_nativeUploadCursor(JNIEnv *env, jobject thiz,
else else
scratch[z++] = fb[fbY * client->fbRealWidth + fbX]; scratch[z++] = fb[fbY * client->fbRealWidth + fbX];
if (left == 0 && top == 0) { if (left == -1 && top == -1) {
left = fbX; left = fbX;
top = fbY; top = fbY;
} }
@ -489,7 +489,7 @@ Java_com_gaurav_avnc_vnc_VncClient_nativeUploadCursor(JNIEnv *env, jobject thiz,
} }
} }
if (right > left && bottom > top) if (left >= 0 && top >= 0)
glTexSubImage2D(GL_TEXTURE_2D, glTexSubImage2D(GL_TEXTURE_2D,
0, 0,
left, left,